Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow style attributes with hex values. #247

Merged
merged 2 commits into from Jan 8, 2019

Conversation

alexjeffburke
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Jan 8, 2019

Pull Request Test Coverage Report for Build 978

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.751%

Totals Coverage Status
Change from base Build 974: 0.0%
Covered Lines: 519
Relevant Lines: 548

💛 - Coveralls

@sunesimonsen
Copy link
Member

Ups 👍

@alexjeffburke alexjeffburke merged commit a320913 into master Jan 8, 2019
@alexjeffburke alexjeffburke deleted the fix/style-attribute-with-hex-value branch December 23, 2019 14:59
sunesimonsen added a commit that referenced this pull request Nov 28, 2023
After #247 the style
regex became way too restrictive and doesn't allow shorthand values
like:

border: thin solid red;

So I think we should just completely relax the style regex as it isn't
really giving us any value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants