Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jsdom to version 14.0.0 #257

Merged
merged 1 commit into from Mar 11, 2019
Merged

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Mar 11, 2019

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ jsdom (^13.0.0 → ^14.0.0) · Repo · Changelog

Release Notes

14.0.0 (from changelog)

Breaking changes:

  • JSDOM.fragment() now creates fragments whose document has no browsing context, i.e. no associated Window. This means the defaultView property will be null, resources will not load, etc.
  • JSDOM.fragment(), called with no arguments, now creates a DocumentFragment with no children, instead of with a single child text node whose data was "undefined".

Other changes:

  • Fixed a regression in v13.2.0 when calling element.blur() on a focused element.
  • Fixed inserting <link> elements into documents with no browsing context to no longer crash if the originating JSDOM was configured to fetch the resource. Now, per spec, <link> elements only attempt to fetch if they are browsing-context connected.
  • Fixed <template> elements to have the correct semantics, of using a separate browsing-context-less document to store its contents. In particular this means resources will not be fetched for elements inside the <template>, as per spec.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 6 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Mar 11, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1070

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.75%

Totals Coverage Status
Change from base Build 1065: 0.0%
Covered Lines: 649
Relevant Lines: 677

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Mar 11, 2019

Pull Request Test Coverage Report for Build 1070

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.75%

Totals Coverage Status
Change from base Build 1065: 0.0%
Covered Lines: 649
Relevant Lines: 677

💛 - Coveralls

@papandreou papandreou merged commit 7ff7d75 into master Mar 11, 2019
@depfu depfu bot deleted the depfu/update/npm/jsdom-14.0.0 branch March 11, 2019 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants