New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always sort the attributes by name #261

Closed

sunesimonsen wants to merge 1 commit into master from ssimonsen/order-attributes

Member

sunesimonsen commented Apr 13, 2019

This will make the output more readable and make the output stable across DOM implementations.


          Always sort the attributes

3364a27

sunesimonsen force-pushed the ssimonsen/order-attributes branch from cc58178 to 3364a27 Compare

April 13, 2019 18:57

sunesimonsen requested review from papandreou and alexjeffburke

April 13, 2019 18:58

coveralls commented Apr 13, 2019 •

edited

Pull Request Test Coverage Report for Build 1094

11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.75%

Totals
Change from base Build 1079:	0.0%
Covered Lines:	649
Relevant Lines:	677

💛 - Coveralls

coveralls commented Apr 13, 2019

Pull Request Test Coverage Report for Build 1092

11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.75%

Totals
Change from base Build 1079:	0.0%
Covered Lines:	649
Relevant Lines:	677

💛 - Coveralls

alexjeffburke approved these changes

View reviewed changes

Member

alexjeffburke left a comment

Looks great!

Soon as it’s merged I’ll lay my branch on top and we can see what the situation is with IE

Member

alexjeffburke commented Apr 19, 2019

Supersded by #264.

alexjeffburke closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment