Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced some more output tests with snapshots #273

Merged
merged 2 commits into from
Jun 17, 2019
Merged

Replaced some more output tests with snapshots #273

merged 2 commits into from
Jun 17, 2019

Conversation

sunesimonsen
Copy link
Member

No description provided.

@sunesimonsen
Copy link
Member Author

I don't like the wording of this to error satisfying to equal snapshot but let's see if we can come up with native support that is more appropriate.

@sunesimonsen
Copy link
Member Author

We could consider using to have error message matching snapshot and use that for both to throw and to error.

@sunesimonsen sunesimonsen force-pushed the ssimonsen/some-more-snapshots branch from 05d823e to 5cb5ac3 Compare June 15, 2019 19:37
@coveralls
Copy link

coveralls commented Jun 15, 2019 •
edited

Pull Request Test Coverage Report for Build 1168

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 93.509%
Totals Coverage Status
Change from base Build 1156: 0.05%
Covered Lines: 658
Relevant Lines: 687
💛 - Coveralls

@sunesimonsen sunesimonsen force-pushed the ssimonsen/some-more-snapshots branch from 5cb5ac3 to 6cadad1 Compare June 15, 2019 19:44
@sunesimonsen sunesimonsen force-pushed the ssimonsen/some-more-snapshots branch from d66264b to 0c7124a Compare June 15, 2019 20:39
papandreou
papandreou approved these changes Jun 16, 2019
View reviewed changes
Copy link
Member

@papandreou papandreou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This reminds me that the recording mode of u-snapshot probably doesn't support replacing to equal snapshot with to inspect as snapshot inside a compound assertion. Will look into that :)

@papandreou
Copy link
Member

Will look into that

Fixed in unexpectedjs/unexpected-snapshot@c893771

@sunesimonsen sunesimonsen merged commit c00a4f5 into master Jun 17, 2019
@sunesimonsen sunesimonsen deleted the ssimonsen/some-more-snapshots branch June 17, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@papandreou papandreou papandreou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sunesimonsen @coveralls @papandreou