Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html document type and "queried for" assertion #3

Merged

Conversation

papandreou
Copy link
Member

The identify function of HTMLDocument should probably be improved, but I had a little trouble understanding the overall strategy for detecting these instances in both the browser and jsdom.

queried for is the spike I mentioned on the unexpected gitter. It's one out of many possible takes on how to add querying support.

@Munter
Copy link
Member

Munter commented Mar 6, 2015

I'm a bit unsure of the queried for assertion as it's quite like what I'd want to have in to have childrenwith a query selector. But we're far from stable, so merging and then we can take a closer look at the API when there are enough primitives at hand

Munter added a commit that referenced this pull request Mar 6, 2015
…sertion

Html document type and "queried for" assertion
@Munter Munter merged commit 6449070 into unexpectedjs:master Mar 6, 2015
@Munter
Copy link
Member

Munter commented Mar 6, 2015

Published in v0.2.0

@papandreou
Copy link
Member Author

That's fair enough, thanks!

Btw. I forgot to provide an equals function for the HTMLDocument type, which means it will use DOMNode's, and that won't be correct. I think we'll need some serialization code that'll take an entire document before that can be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants