Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Unexpected 10 #38

Merged
merged 11 commits into from
Oct 9, 2015
Merged

Conversation

papandreou
Copy link
Member

Cuts compatibility with Unexpected 9 and below, sorry.

Bonus features:

  • when parsed as, when queried for: Make 'when' optional and provide the result as the fulfillment value if no assertion is provided.
  • Add support for satisfying DOMNodeList against strings and DOMNodeList. Exploit it to support expect(domElement, 'to satisfy', children: 'foo<span>bar</span>');
  • queried for: Don't put CSS selectors in quotes in the error messages

Also do some cleanup, and define assertions for DOMDocumentFragment where applicable.
Exploit it to support expect(domElement, 'to satisfy', children: 'foo<span>bar</span>');
…ges when many middle-of-the-rocket assertions are in play.

Works when linked against unexpected feature/v10-shift

[ci skip]
…e result as the fulfillment value if no assertion is provided.

Works when linked against feature/v10-shift
…achedDOMNodeList as well, re-fixing 2 tests."

This reverts commit 216657f.
Munter added a commit that referenced this pull request Oct 9, 2015
@Munter Munter merged commit 9c5195c into unexpectedjs:master Oct 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants