-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document extended assertions #6
Document extended assertions #6
Conversation
It is probably a good idea to mention http://unexpectedjs.github.io/api/addAssertion/ if we don't already. |
There was an example in the docs already using a custom assertion - I hoped to make it even clearer with the addition of an obvious section title for it in the first of the commits :) But perhaps it's worth adding a link to those docs too? |
Ugh that's what happens when you rush to get something done :) Thanks for the review, I'll force push with a fixup tomorrow morning! |
Thanks a lot for the contribution! Certainly a nice improvement. Would be great having the link now that we finally have something to link to. |
I've just forced push this with the corrections and an additional link to the unexpected addAssertion documentation :) |
Document extended assertions
Thanks a lot! |
Hey,
See what you think of this - I added some documentation about the extended assertions. Now I've done it I realise I've mixed in some other changes here too.. if you'd prefer I take those out just shout :)
AJB