Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document extended assertions #6

Merged
merged 3 commits into from
Apr 24, 2015
Merged

Document extended assertions #6

merged 3 commits into from
Apr 24, 2015

Conversation

alexjeffburke
Copy link
Member

Hey,

See what you think of this - I added some documentation about the extended assertions. Now I've done it I realise I've mixed in some other changes here too.. if you'd prefer I take those out just shout :)

AJB

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.92% when pulling b88a508 on alexjeffburke:document-extended-assertions into 61fff65 on unexpectedjs:master.

@sunesimonsen
Copy link
Member

It is probably a good idea to mention http://unexpectedjs.github.io/api/addAssertion/ if we don't already.

@alexjeffburke
Copy link
Member Author

There was an example in the docs already using a custom assertion - I hoped to make it even clearer with the addition of an obvious section title for it in the first of the commits :) But perhaps it's worth adding a link to those docs too?

@alexjeffburke
Copy link
Member Author

Ugh that's what happens when you rush to get something done :) Thanks for the review, I'll force push with a fixup tomorrow morning!

@papandreou
Copy link
Member

Thanks a lot for the contribution! Certainly a nice improvement.

Would be great having the link now that we finally have something to link to.

@alexjeffburke
Copy link
Member Author

I've just forced push this with the corrections and an additional link to the unexpected addAssertion documentation :)

papandreou added a commit that referenced this pull request Apr 24, 2015
@papandreou papandreou merged commit 25d4ef6 into unexpectedjs:master Apr 24, 2015
@papandreou
Copy link
Member

Thanks a lot!

@alexjeffburke alexjeffburke deleted the document-extended-assertions branch May 20, 2015 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants