Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eslint-config-prettier to version 4.0.0 #11

Merged
merged 1 commit into from Jan 27, 2019

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Jan 27, 2019

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ eslint-config-prettier (^3.6.0 → ^4.0.0) · Repo · Changelog

Release Notes

4.0.0 (from changelog)

  • Breaking change: Support for eslint-plugin-typescript has been removed and replaced with support for its successor @typescript-eslint/eslint-plugin. Thanks to TANIGUCHI Masaya (@ta2gch) and everyone else who helped with this!
  • Changed: arrow-body-style and prefer-arrow-callback are now marked as special rules, since they might cause problems if using eslint-plugin-prettier and --fix. They are turned off by default, and the CLI helper tool will warn about them (but not error if you do enable them). This won’t break your linting checks, but do note that these rules will be disabled unless you explicitly enable them again, and that you might see new warnings when running the CLI helper tool.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 5 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Jan 27, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2406657 on depfu/update/npm/eslint-config-prettier-4.0.0 into 1da41e5 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2406657 on depfu/update/npm/eslint-config-prettier-4.0.0 into 1da41e5 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2406657 on depfu/update/npm/eslint-config-prettier-4.0.0 into 1da41e5 on master.

@papandreou papandreou merged commit 07d3760 into master Jan 27, 2019
@depfu depfu bot deleted the depfu/update/npm/eslint-config-prettier-4.0.0 branch January 27, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants