Skip to content

Commit

Permalink
Merge 1e1c900 into 0565a47
Browse files Browse the repository at this point in the history
  • Loading branch information
joelmukuthu committed Sep 17, 2023
2 parents 0565a47 + 1e1c900 commit e9d0e0e
Show file tree
Hide file tree
Showing 7 changed files with 531 additions and 510 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
Expand Up @@ -2,9 +2,9 @@ name: CI

on:
push:
branches: [ master ]
branches: [master]
pull_request:
branches: [ master ]
branches: [master]

jobs:
lint:
Expand All @@ -14,10 +14,10 @@ jobs:
- name: Checkout code
uses: actions/checkout@v2

- name: Use Node.js 12.x
- name: Use Node.js 18.x
uses: actions/setup-node@v1
with:
node-version: 12.x
node-version: 18.x

- name: Use npm cache
uses: actions/cache@v1
Expand All @@ -38,7 +38,7 @@ jobs:

strategy:
matrix:
node-version: [10.x, 12.x]
node-version: [12.x, 14.x, 16.x, 18.x]

services:
postgres9:
Expand Down Expand Up @@ -80,7 +80,7 @@ jobs:
PGPORT: 5432

- name: Send coverage to coveralls
if: matrix.node-version == '12.x'
if: matrix.node-version == '18.x'
uses: coverallsapp/github-action@master
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
1 change: 1 addition & 0 deletions .npmrc
@@ -1,2 +1,3 @@
package-lock = false
save-exact = false
legacy-peer-deps = true
2 changes: 1 addition & 1 deletion .nvmrc
@@ -1 +1 @@
12
18
6 changes: 3 additions & 3 deletions README.md
Expand Up @@ -67,7 +67,7 @@ describe('migrations', function () {
return expect(knex, 'to have table', 'user').and('to have columns', {
user: ['id', 'first_name', 'last_name'],
});
}
},
);
});
});
Expand Down Expand Up @@ -173,7 +173,7 @@ exports.up = function (knex) {
return knex('user')
.where('id', '=', user.id)
.update('name', user.first_name + ' ' + user.last_name);
})
}),
);
});
})
Expand Down Expand Up @@ -202,7 +202,7 @@ exports.down = function (knex) {
first_name: names[0],
last_name: names[1],
});
})
}),
);
});
})
Expand Down

0 comments on commit e9d0e0e

Please sign in to comment.