Tech/update linting setup #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 21, 2019
|
Hey @papandreou, do you want to give this another go, now that I've managed to upgrade past Node.js 6 (ref)? |
* master: 3.0.0 chore(ci): drop Node.js 6 from the test matrix fix: support latest knex version (v0.20.13) chore: update knex to v0.20.13 chore: update mocha to v7 chore: run tests on Node.js 12 locally chore: switch dev environment to Node.js 12 test: do not assert on `require` error messages chore: add a password for the postgres db chore: fix lint errors chore: remove unexpected-fs and use mock-fs directly chore(ci): add Node.js 6 to the test matrix chore: remove Travic CI builds chore(ci): refactor `npm ci` => `npm install` chore(nyc): enable text and lcov reports by default chore: add GitHub Actions file fix: display rejection reason for failed queries refactor: forward flags to expect.it chore: remove unnecessary COPY directive Update proxyquire to version 2.1.2
papandreou
force-pushed
the
tech/updateLintingSetup
branch
from
7afcb63
to
1e44d07
Compare
|
@joelmukuthu, there! |
|
How awesome you are! 🤗 |
|
@joelmukuthu, yw! I guess you might want to upgrade to prettier 2.x while you're at it, but I left that out of this PR. |
|
I can also turn depfu back on if you want? I turned it off because there wasn't much action here :) |
|
Yes, let's turn it back on although I don't often react too fast to it for dev dependencies. And we can also handle the prettier 2.x update that way :) And yeah, besides keeping this up to date with Knex I don't think I'll be doing too much in the way of new features unfortunately. |
|
It's back on! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by #66
Blocked by unexpected-fs, which prevents upgrading past node.js 6 😟