Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESM build #19

Merged
merged 2 commits into from
Aug 25, 2019
Merged

ESM build #19

merged 2 commits into from
Aug 25, 2019

Conversation

alexjeffburke
Copy link
Member

No description provided.

@alexjeffburke alexjeffburke mentioned this pull request Aug 7, 2019
Merged
@coveralls
Copy link

coveralls commented Aug 7, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 66.667% when pulling 0cfb8d4 on feature/deno into 4452d33 on master.

@alexjeffburke
Build unexpected-magicpen with rollup.
a20ff40
@alexjeffburke
Add esm build.
0cfb8d4 
Ensure the output file is included in the package.
@alexjeffburke alexjeffburke changed the title WIP: deno support ESM build Aug 25, 2019
@alexjeffburke
Copy link
Member Author

@papandreou the last commit is not intended to land - it was only necessary to support using a github URL in the PR to Unexpected core to demonstrate it working. Will remove before landing :)

papandreou
papandreou approved these changes Aug 25, 2019
View reviewed changes
Copy link
Member

@papandreou papandreou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine! I'm curious why it's necessary to have an esm build of this plugin, though?

@alexjeffburke
Copy link
Member Author

@papandreou ah, it’s because the core test suite loads this plugin. In order to minimise complexity it was easier to have an esm build of this and do only the tests in core than much more involved fiddling with the core Makefile to somehow squeeze building it in there.

@papandreou
Copy link
Member

Ah, okay. It's fine, really :)

@alexjeffburke alexjeffburke merged commit a7ff606 into master Aug 25, 2019
@alexjeffburke alexjeffburke deleted the feature/deno branch August 25, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@papandreou papandreou papandreou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexjeffburke @coveralls @papandreou