Skip to content

Commit

Permalink
Change unexpected-documentation-site-generator to a devDependency
Browse files Browse the repository at this point in the history
It was moved from devDeps to optionalDependencies in this commit:
1efd196

I tested installing the module on node 6 and did not find any errors, so
it seems safe to "revert" this change.

And optionalDependency is not a suitable replacement for a devDependency
as it will also be installed when consumers install the module. If this
change is not enough, we might need to consider installing it lazily -
as in, only install it just-in-time before invoking the build commands.
  • Loading branch information
gustavnikolaj committed Mar 11, 2019
1 parent 25d4518 commit cd34729
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions package.json
Expand Up @@ -23,9 +23,6 @@
"peerDependencies": {
"unexpected": "^10.27.0 || ^11.0.0-3"
},
"optionalDependencies": {
"unexpected-documentation-site-generator": "^5.0.0"
},
"devDependencies": {
"body-parser": "^1.18.2",
"coveralls": "^3.0.0",
Expand All @@ -42,6 +39,7 @@
"sinon": "^7.0.0",
"socketerrors-papandreou": "^0.2.0-patch2",
"unexpected": "^11.0.0-3",
"unexpected-documentation-site-generator": "^5.0.0",
"unexpected-express": "^11.0.0",
"unexpected-http": "^6.0.0",
"unexpected-markdown": "^3.0.0",
Expand Down

0 comments on commit cd34729

Please sign in to comment.