Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prettier, switch to 2 space indent, and auto-modernize the code base a bit #65

Merged
merged 31 commits into from Sep 23, 2018
Merged

Add prettier, switch to 2 space indent, and auto-modernize the code base a bit #65

merged 31 commits into from Sep 23, 2018

Conversation

papandreou
Copy link
Member

@papandreou papandreou commented Sep 23, 2018 •
edited

Some of the inspected arrow functions look a bit funky, because Unexpected's function type fails to detect their indentation for some reason. Will try to fix that as a separate thing later.

@papandreou
Add a prettier setup
20da015
@papandreou
Update .editorconfig to specify 2 space indentation
d1f38f8
@papandreou
eslint --fix .
0687db9
@papandreou
Fix lint
813ba23
@papandreou
Ditch extra newlines between requires
14be19e
@papandreou
Fix tests that depend on exact error messages with now prettier'ed fu…
24bbcdc 
…nction source
@papandreou
lebab --replace lib --replace test --transform arrow
db37190
@papandreou
lebab --replace lib --replace test --transform arrow-return
7334ae0
@papandreou
lebab --replace lib --replace test --transform obj-method
3d9e557
@papandreou
lebab --replace lib --replace test --transform obj-shorthand
cf2534e
@papandreou
lebab --replace lib --replace test --transform multi-var
f8c2594
@papandreou
lebab --replace lib --replace test --transform let
0d84631
@papandreou
lebab --replace lib --replace test --transform template
2863a20
@papandreou
lebab --replace lib --replace test --transform destruct-param
94740be
@papandreou
eslint --fix .
36b1b76
@papandreou
Use destructuring instead of BluebirdPromise#spread
d585e94
@papandreou
Fix silly use of a wrapped setImmediate
2acb78f
@papandreou
lebab --transform let --replace lib
6b4554a
@papandreou
lebab --replace lib --transform arrow
fce5890
@papandreou
lebab --replace lib --transform arrow-return
52045c3
@papandreou
lebab --replace lib --transform arg-rest
c54e980
@papandreou
lebab --replace lib --transform obj-method
4f112ac
@papandreou
lebab --replace lib --transform obj-shorthand
a5be8a5
@papandreou
lebab --replace lib --transform class
a7cf4c0
@papandreou
lebab --replace lib --transform default-param
8a5beec
@papandreou
lebab --replace lib --transform template
8f47d8c
@papandreou
eslint --fix .
6cb070e
@papandreou
Fix expected output in tests again
5bde1d7
@papandreou papandreou changed the title Add prettier and auto-modernize the code base a bit Add prettier, switch to 2 space indent, and auto-modernize the code base a bit Sep 23, 2018
@coveralls
Copy link

coveralls commented Sep 23, 2018 •
edited

Coverage Status

Coverage decreased (-0.02%) to 96.693% when pulling 8432af2 on chore/prettierAndModernize into 43897a3 on master.

alexjeffburke
alexjeffburke approved these changes Sep 23, 2018
View reviewed changes
Copy link
Member

@alexjeffburke alexjeffburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So great to get it done to this tree 👍

@papandreou papandreou merged commit db2361a into master Sep 23, 2018
@papandreou papandreou deleted the chore/prettierAndModernize branch September 23, 2018 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjeffburke alexjeffburke alexjeffburke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@papandreou @coveralls @alexjeffburke