Separate recorder #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mocker records all circumstances, even errors, in its timeline such that all assertions can be done after the fact. Start doing this for the recorder - make the value when resolving uniform and set the timeline and fulfilmentValue on the instance. Use the opportunity to align naming by doubling down on "timeline".
As of this commit the recorder does not directly return a rejection. Instead, much like the mocker, it records the last error it saw as part of its timeline. Assertions that execute against it now iterate over this timeline and will throw on seeing an error if required.
papandreou
approved these changes
Nov 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits our the http recorder from the unexpected-mitm assertion code and uses a similar approach to the mocker to allow a self contained
UnexpectedMitmRecorderthat is constructed and whose instances can subsequently be asserted against.The current assertions making use of recording functionality are converted to make use of this new class. The set of internal assertions used to validate the mocker are expanded to support checking the recorder contained no errors and throwing it it did.