Merge pull request #521 from unexpectedjs/feature/eslint-plugin-mocha

Add and configure eslint-plugin-mocha
unexpectedjs · Sep 29, 2018 · a319eaf · a319eaf
2 parents 5d250a8 + f08e726
commit a319eaf
Show file tree

Hide file tree

Showing 6 changed files with 23 additions and 49 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -1,6 +1,6 @@
 const config = {
   extends: ['pretty-standard'],
-  plugins: ['import'],
+  plugins: ['import', 'mocha'],
   rules: {
     'import/no-extraneous-dependencies': [
       'error',
@@ -12,7 +12,10 @@ const config = {
         optionalDependencies: false,
         peerDependencies: false
       }
-    ]
+    ],
+    'mocha/no-exclusive-tests': 'error',
+    'mocha/no-nested-tests': 'error',
+    'mocha/no-identical-title': 'error'
   }
 };
 

diff --git a/package.json b/package.json
@@ -41,6 +41,7 @@
     "eslint": "^4.17.0",
     "eslint-config-pretty-standard": "^1.2.0",
     "eslint-plugin-import": "^2.8.0",
+    "eslint-plugin-mocha": "^5.2.0",
     "eslint-plugin-prettier": "^2.6.0",
     "find-node-modules": "^1.0.4",
     "gh-pages": "^1.1.0",

diff --git a/test/api/child.spec.js b/test/api/child.spec.js
@@ -125,23 +125,6 @@ describe('#child', function() {
     childExpect('yaddafoobar', 'to foobar');
   });
 
-  it('should prefer a style defined in the child, even if it was added before an identically named one in the parent', function() {
-    childExpect.addStyle('yadda', function() {
-      this.text('yaddagood');
-    });
-    parentExpect.addStyle('yadda', function() {
-      this.text('yaddabad');
-    });
-    expect(
-      childExpect
-        .createOutput('text')
-        .yadda()
-        .toString(),
-      'to equal',
-      'yaddagood'
-    );
-  });
-
   it('should allow installing an identically named plugin', function() {
     parentExpect.use({
       name: 'foo',

diff --git a/test/assertions/to-satisfy.spec.js b/test/assertions/to-satisfy.spec.js
@@ -77,18 +77,20 @@ describe('to satisfy assertion', function() {
       );
     });
 
-    it('should fail', function() {
-      expect(
-        function() {
-          expect({ foo: {} }, 'to satisfy', { foo: [] });
-        },
-        'to throw',
-        'expected { foo: {} } to satisfy { foo: [] }\n' +
-          '\n' +
-          '{\n' +
-          '  foo: {} // should satisfy []\n' +
-          '}'
-      );
+    describe('when the array is nested inside an object', function() {
+      it('should fail', function() {
+        expect(
+          function() {
+            expect({ foo: {} }, 'to satisfy', { foo: [] });
+          },
+          'to throw',
+          'expected { foo: {} } to satisfy { foo: [] }\n' +
+            '\n' +
+            '{\n' +
+            '  foo: {} // should satisfy []\n' +
+            '}'
+        );
+      });
     });
   });
 

diff --git a/test/assertions/when-fulfilled.spec.js b/test/assertions/when-fulfilled.spec.js
@@ -59,21 +59,6 @@ describe('when fulfilled adverbial assertion', function() {
     );
   });
 
-  it('should fail when the promise is rejected with a value of undefined', function() {
-    return expect(
-      expect(
-        new Promise(function(resolve, reject) {
-          setTimeout(reject, 0);
-        }),
-        'when fulfilled',
-        'to be truthy'
-      ),
-      'to be rejected with',
-      'expected Promise when fulfilled to be truthy\n' +
-        '  Promise unexpectedly rejected'
-    );
-  });
-
   it('should fail when the next assertion fails', function() {
     return expect(
       expect(

diff --git a/test/types/function-type.spec.js b/test/types/function-type.spec.js
@@ -228,7 +228,7 @@ describe('function type', function() {
   } catch (e) {}
 
   if (arrowFunctionWith1SpaceIndentAndLeadingNewline) {
-    it('should reindent an implicit return multiline arrow function', function() {
+    it('should reindent an implicit return multiline arrow function with 1 space indent', function() {
       expect(
         arrowFunctionWith1SpaceIndentAndLeadingNewline,
         'to inspect as',
@@ -247,7 +247,7 @@ describe('function type', function() {
   } catch (e) {}
 
   if (arrowFunctionWith2SpaceIndentAndLeadingNewline) {
-    it('should reindent an implicit return multiline arrow function', function() {
+    it('should reindent an implicit return multiline arrow function with 2 space indent', function() {
       expect(
         arrowFunctionWith2SpaceIndentAndLeadingNewline,
         'to inspect as',
@@ -285,7 +285,7 @@ describe('function type', function() {
   } catch (e) {}
 
   if (arrowFunctionWith4SpaceIndentAndLeadingNewline) {
-    it('should reindent an implicit return multiline arrow function with 4 space indent', function() {
+    it('should reindent an implicit return multiline arrow function with long leading indent', function() {
       expect(
         arrowFunctionWith4SpaceIndentAndLeadingNewline,
         'to inspect as',