Fix error message of 'when fulfilled' with expect.it #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| }; | ||
| if (expect.findTypeOf(nextAssertion).is('expect.it')) { | ||
| // Force a failing expect.it error message to be property nested instead of replacing the default error message: |
There was a problem hiding this comment.
@sunesimonsen Can you come up with an idea that could help avoid this construct? The special handling of errors from expect.it, that is.
There was a problem hiding this comment.
Wouldn't the improved type system help here?
There was a problem hiding this comment.
I don't think it would, it seems like there's an expect.it quirk in play here. Ideally shifting to an expect.it and an assertion string should behave the same. If you check out the branch and remove the special casing of the expect.it here, the assertion inside the should fail with the right error message when the next assertion is an expect.it that fails test fails like this:
expected { foo: 'bar' } to have property 'foo' with a value of 'quux'
-bar
+quux
But I want it to fail like this:
expected Promise when fulfilled expect.it('to have property', 'foo', 'quux')
expected { foo: 'bar' } to have property 'foo' with a value of 'quux'
-bar
+quux
papandreou
added a commit
that referenced
this pull request
Aug 8, 2015
Fix error message of 'when fulfilled' with expect.it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.