Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop compatibility with pre-10.10.0 type.diff return values #407

Merged
merged 1 commit into from Sep 9, 2018

Conversation

@papandreou
Copy link
Member

@papandreou papandreou commented Jul 15, 2017

The diff method used to return { inline: <boolean>, diff: <magicPen> }, but that was changed in e22bdef with a backwards compatibility hack that installed a self-referencing 'diff' property.

I suggest we remove the backwards compatibility in Unexpected 11.

  • check up on unexpected-react, which seems to rely on the backwards compatibility.

Depends on these:

@papandreou papandreou added this to the v11 milestone Jul 15, 2017
papandreou added a commit to papandreou/unexpected-htmllike that referenced this pull request Jul 15, 2017
papandreou added a commit to papandreou/unexpected-react that referenced this pull request Jul 15, 2017
@sunesimonsen
Copy link
Member

@sunesimonsen sunesimonsen commented Jul 15, 2017

@papandreou papandreou force-pushed the feature/dropCompatibilityWithOldDiffResults branch from d30ca17 to d8e85ee Jul 15, 2017
@alexjeffburke alexjeffburke mentioned this pull request Jul 1, 2018
5 of 5 tasks complete
@sunesimonsen sunesimonsen changed the base branch from master to v11 Sep 5, 2018
The diff method used to return { inline: <boolean>, diff: <magicPen> },
but that was changed in e22bdef with a backwards compatibility hack
that installed a self-referencing 'diff' property.

I suggest we remove the backwards compatibility in Unexpected 11.
@sunesimonsen sunesimonsen force-pushed the feature/dropCompatibilityWithOldDiffResults branch from d8e85ee to 3dfdeeb Sep 5, 2018
@papandreou
Copy link
Member Author

@papandreou papandreou commented Sep 6, 2018

@sunesimonsen, you're welcome to merge into v11 whenever you see fit :)

@sunesimonsen sunesimonsen merged commit feb32d1 into v11 Sep 9, 2018
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-0.006%) to 98.164%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@sunesimonsen sunesimonsen deleted the feature/dropCompatibilityWithOldDiffResults branch Sep 9, 2018
@sunesimonsen sunesimonsen mentioned this pull request Sep 9, 2018
25 of 25 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants