Drop compatibility with pre-10.10.0 type.diff return values #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papandreou
added a commit
to papandreou/unexpected-htmllike
that referenced
this pull request
Jul 15, 2017
It might be removed in Unexpevted 11: unexpectedjs/unexpected#407
papandreou
added a commit
to papandreou/unexpected-react
that referenced
this pull request
Jul 15, 2017
It might be removed in Unexpected 11: unexpectedjs/unexpected#407
|
👍
…On Sat, 15 Jul 2017 at 16.07, Andreas Lind ***@***.***> wrote:
The diff method used to return { inline: , diff: }, but that was changed
in e22bdef
<e22bdef>
with a backwards compatibility hack that installed a self-referencing
'diff' property.
I suggest we remove the backwards compatibility in Unexpected 11.
- check up on unexpected-react, which seems to rely on the backwards
compatibility.
------------------------------
You can view, comment on, or merge this pull request online at:
#407
Commit Summary
- Drop compatibility with pre-10.10.0 type.diff return values
File Changes
- *M* lib/Unexpected.js
<https://github.com/unexpectedjs/unexpected/pull/407/files#diff-0>
(26)
- *M* lib/UnexpectedError.js
<https://github.com/unexpectedjs/unexpected/pull/407/files#diff-1> (5)
- *D* lib/makeDiffResultBackwardsCompatible.js
<https://github.com/unexpectedjs/unexpected/pull/407/files#diff-2>
(19)
- *M* test/api/addType.spec.js
<https://github.com/unexpectedjs/unexpected/pull/407/files#diff-3>
(37)
- *M* test/api/fail.spec.js
<https://github.com/unexpectedjs/unexpected/pull/407/files#diff-4>
(21)
Patch Links:
- https://github.com/unexpectedjs/unexpected/pull/407.patch
- https://github.com/unexpectedjs/unexpected/pull/407.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#407>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFism-j3g6Tgob4caaxuOrmYy3FiV1yks5sOMeIgaJpZM4OZBlT>
.
|
papandreou
force-pushed
the
feature/dropCompatibilityWithOldDiffResults
branch
from
d30ca17
to
d8e85ee
Compare
sunesimonsen
approved these changes
Aug 1, 2017
The diff method used to return { inline: <boolean>, diff: <magicPen> },
but that was changed in e22bdef with a backwards compatibility hack
that installed a self-referencing 'diff' property.
I suggest we remove the backwards compatibility in Unexpected 11.
sunesimonsen
force-pushed
the
feature/dropCompatibilityWithOldDiffResults
branch
from
d8e85ee
to
3dfdeeb
Compare
sunesimonsen
approved these changes
Sep 6, 2018
|
@sunesimonsen, you're welcome to merge into v11 whenever you see fit :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff method used to return { inline: <boolean>, diff: <magicPen> }, but that was changed in e22bdef with a backwards compatibility hack that installed a self-referencing 'diff' property.
I suggest we remove the backwards compatibility in Unexpected 11.
Depends on these: