Freeze the top-level expect - #517
Merged
Merged
Conversation
As discussed on #476 [semver-major]
alexjeffburke
approved these changes
Sep 29, 2018
alexjeffburke
left a comment
alexjeffburke
left a comment
Member
There was a problem hiding this comment.
Big 👍 from me - I think this removes a sizeable footgun for those using the library the first time.
I do wonder if we want to add a task to revise the sections talking about adding assertions and using plugins to make this new reality clear.
| topLevelExpect.addAssertion('<any> to foo', function() {}); | ||
| }, | ||
| 'to throw', | ||
| 'Cannot add an assertion to a frozen instance, please run .clone() first' |
sunesimonsen
approved these changes
Sep 29, 2018
sunesimonsen
left a comment
sunesimonsen
left a comment
Member
There was a problem hiding this comment.
👍
Did you see any performance penalty?
Member
Author
|
I can't imagine there would be? The only change is that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on #476