-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added karma, mocha, chrome headless setup #540
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunesimonsen
changed the title
Added karma, mocha, chrome headless setup
[WIP] Added karma, mocha, chrome headless setup
Dec 11, 2018
sunesimonsen
force-pushed
the
ssimonsen/browser-tests
branch
2 times, most recently
from
December 21, 2018 20:03
2860f8c
to
932ceb8
Compare
sunesimonsen
force-pushed
the
ssimonsen/browser-tests
branch
from
December 21, 2018 20:04
932ceb8
to
9cbe8b0
Compare
sunesimonsen
force-pushed
the
ssimonsen/browser-tests
branch
from
December 21, 2018 20:07
b04025e
to
f4be49c
Compare
We no longer test with PhantomJS, so we might as well remove the special casing for it.
sunesimonsen
force-pushed
the
ssimonsen/browser-tests
branch
from
December 25, 2018 09:33
31e94e8
to
9157981
Compare
papandreou
approved these changes
Dec 25, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! 🚀
sunesimonsen
changed the title
[WIP] Added karma, mocha, chrome headless setup
Added karma, mocha, chrome headless setup
Dec 25, 2018
papandreou
reviewed
Dec 25, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning! do not merge before we have a Browserstack setup, as we need to make sure that we stay compatible with old stuff like IE11.
This PR introduces a Karma browser test setup to replace the old browser tests. It also sets up a build matrix that will run the browser tests on Chrome headless and IE11.