Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unexpected messy missing diff #547

Merged
merged 2 commits into from
Dec 29, 2018
Merged

Fix unexpected messy missing diff #547

merged 2 commits into from
Dec 29, 2018

Conversation

sunesimonsen
Copy link
Member

When running unexpected-messy against v11 we get a missing diff. This PR should fix the problem.

@sunesimonsen sunesimonsen changed the base branch from master to v11 December 28, 2018 16:07
alexjeffburke
alexjeffburke approved these changes Dec 29, 2018
View reviewed changes
Copy link
Member

@alexjeffburke alexjeffburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it now! The types were such that it didn't result in the error message being appended when an object was satisfied against an expect.it. Great spot - this is a little subtle :)

@sunesimonsen sunesimonsen merged commit 538d1a4 into v11 Dec 29, 2018
@sunesimonsen sunesimonsen deleted the ssimonsen/fix-unexpected-messy-missing-diff branch December 29, 2018 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjeffburke alexjeffburke alexjeffburke approved these changes

@papandreou papandreou Awaiting requested review from papandreou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sunesimonsen @alexjeffburke