-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] migration guide #552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is absolutely awesome, thanks you so much!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you so much for picking this up!
I think I would put the ####
sections in exactly the opposite order, so (what I perceive to be) the most impactful breaking changes would be mentioned first.
Most importantly place the function by value information after the expect.it() information because it builds on it.
@sunesimonsen @papandreou this could do with a fresh read by both of you :) |
I think we need a way to control the order of the pages in the top menu, and maybe whether they appear there at all. It's pushing out the plugins page on small screens in portrait mode: If we solve that, we should also move the Releases section to a separate page. |
I don't want the migration to be a menu point, I don't think it is important enough for that. But let's solve that technically. |
I think you're both right that this doesn't need to be a top level menu - only did that because it was easy. Perhaps Releases is the way to go and migration is linked to or something. |
@papandreou have hopefully addressed all your comments in the last push :) |
@@ -0,0 +1,187 @@ | |||
--- | |||
title: Migration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the title should be "Migration to Unexpected 11"? Or maybe it would be better to also list migration guides for future versions here, but then the heading below (line 8) should be "Migration to Unexpected 11" or similar.
Looks great! I guess what's missing is then:
Edit: The two last ones are fixed in #560 |
This commit adds a first iteration of a migration guide for v11.