Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspect Buffers with Buffer.from([0x00, ...]) instead of Buffer([0x00, ...]) #632

Merged
merged 1 commit into from May 10, 2019

Conversation

papandreou
Copy link
Member

Avoids noisy deprecation warning from node 10+ when the output is copy/pasted into code:

DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

…, ...])

Avoids noisy deprecation warning from node 10+ when the output is
copy/pasted into code:

  DeprecationWarning: Buffer() is deprecated due to security and usability issues.
  Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
@papandreou papandreou self-assigned this May 9, 2019
Copy link
Member

@sunesimonsen sunesimonsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great.

@papandreou papandreou merged commit 72ea118 into master May 10, 2019
@papandreou papandreou deleted the feature/bufferFrom branch May 10, 2019 19:01
@papandreou
Copy link
Member Author

Released in 11.5.0.

I guess I volunteer to fix the test suites of those plugins that fail 🐦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants