Basic Auth allows for ':' character in passwords

[tobym]

Closes #193

[softprops]

I wonder if we can do this in a way that that avoids creating lists at matches on a regex that more closely describes this

val Credentials = "([^:]*):(.*)".r
":" match { case Credentials(user, pass) =>  (user, pass) } // ("","")
"a:b" match { case Credentials(user, pass) =>  (user, pass) } // (a,b)
"a:b:c" match { case Credentials(user, pass) =>  (user, pass) } // (a,b:c)
"a:" match { case Credentials(user, pass) =>  (user, pass) } // (a,"")
":b" match { case Credentials(user, pass) =>  (user, pass) } // ("",b)

What are your thoughts on that approach?

[n8han]

I'm not a fan of solving it by regex, but I had the same thoughts about this re-joining solution when it was proposed in the issue. Actually, I mentioned this to @tobym in an email about the bug bash, and suggested

I think it would be better to use String.split(":", 1)

So when I saw this PR I assumed my idea didn't work out somehow, and was going to merge. But since we're all here, @tobym , what was the issue with that approach?

[tobym]

string.split(":", 2) is a good option. Will update, along with other test cases. Tests are looking a bit unwieldy though.

[n8han]

Oh, cool. I guess I disagree with java about what "the number of times the pattern is applied" means, but 2 looks like it does what I had in mind.