Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changelist-filter layout bug #83

Closed
wants to merge 1 commit into from

Conversation

TheVaan
Copy link
Contributor

@TheVaan TheVaan commented Jun 7, 2023

Hi,

there is a small layout bug: when opening filter in a changelist view, the backdrop has an offset from the right border of the browsers window.

image

Fix:

  • remove mr-1

Chore:

  • replace {top|bottom|right|left}-0 by inset-0 (same effect with less code)

* remove mr-1
* replace {top|bottom|right|left}-0 by inset-0 (same effect with less code)
@lukasvinclav
Copy link
Contributor

Hi, thanks for update. Tested it and it seems this is will fix the issue but it is needed to compile CSS classes npm run tailwind:build

@lukasvinclav
Copy link
Contributor

Thank you very much for the fix, but I already pushed a desired change with compiled CSS.

@TheVaan TheVaan deleted the patch-1 branch June 17, 2023 11:31
@TheVaan
Copy link
Contributor Author

TheVaan commented Jun 17, 2023

You're welcome. Sorry for not responding in time - I didn’t get notified about your comment so I missed updating my PR.
Thank you for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants