Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Dock led brightness setting doesn't work #178

Closed
1 task done
GitPetri opened this issue Nov 7, 2023 · 6 comments
Closed
1 task done

[bug] Dock led brightness setting doesn't work #178

GitPetri opened this issue Nov 7, 2023 · 6 comments
Assignees
Labels
bug Something isn't working system System level issue web configurator Web configurator related issue

Comments

@GitPetri
Copy link

GitPetri commented Nov 7, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Description

  • Open web configurator
  • Go to a dock setting
  • Set led brightness slider to any value
  • Close dock setting
  • Open dock setting
  • Led brightness is back at default value 66 %

How to Reproduce

  1. Open web configurator
  2. Go to a dock setting
  3. Set led brightness slider to any value. It doesn't matter whether the new value is lower or higher than the default 66 %
  4. Observe 'Change has been saved.' -message on UI
  5. Close dock setting
  6. Open dock setting
  7. Led brightness is back at default value 66 %
image image image

Expected behavior

Setting Led brightness value will set led brightness.

System version

Dock 0.9.2

What part of the system affected by the problem?

Web Configurator, Overall system

Additional context

#51 might be related to this.

@GitPetri GitPetri added the bug Something isn't working label Nov 7, 2023
@github-actions github-actions bot added system System level issue web configurator Web configurator related issue labels Nov 7, 2023
@zehnm
Copy link

zehnm commented Nov 7, 2023

The 66% is only a display issue: the configured value in the dock isn't read out yet. That will be fixed.

Setting the dock brightness value works however. Certain error notifications are still shown, even with brightness set to 0. This has been a design decision, but we will consider a "status LED off" setting, so it always remains dark.

@apgr
Copy link

apgr commented Nov 12, 2023

0% works, but the other settings all seem very bright. It is hard to see the difference

@GitPetri
Copy link
Author

0% works, but the other settings all seem very bright. It is hard to see the difference

I think I saw the difference today (haven't had much time to play with the remote still) by booting up a dock, the initial led intensity was way higher that when the boot cycle ended so for me, yes looks like the 66% is just a display issue like @zehnm states above.

@zehnm
Copy link

zehnm commented Jan 15, 2024

Status update: fix has been released in the BETA group and will be released in the public OTA channel soon.

@zehnm
Copy link

zehnm commented Jan 20, 2024

Showing correct brightness setting is fixed in the just released version 1.6.4

@zehnm zehnm closed this as completed Jan 20, 2024
@spl237
Copy link

spl237 commented Jan 31, 2024

This is not fixed. On my remote and dock, both with the latest firmware, changes to LED brightness in the configurator and the remote claim to have saved, but on returning to the screen are seen to still be the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working system System level issue web configurator Web configurator related issue
Projects
Status: Done
Development

No branches or pull requests

4 participants