Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Dock LED brightness bug has *not* been fixed #304

Closed
1 task done
spl237 opened this issue Jan 31, 2024 · 6 comments
Closed
1 task done

[bug] Dock LED brightness bug has *not* been fixed #304

spl237 opened this issue Jan 31, 2024 · 6 comments
Labels
bug Something isn't working system System level issue web configurator Web configurator related issue

Comments

@spl237
Copy link

spl237 commented Jan 31, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Description

As #178 - this bug is not fixed in the 1.6.7 release.

If I change the dock LED brightness in either the remote or the web configurator, wait for the "change has been saved" message, leave the dock screen and come back, the LED brightness has reverted to the original value.

This bug is not - I repeat not - fixed for me.

How to Reproduce

  1. Go to dock settings in either remote or web configurator
  2. Change LED brightness
  3. Wait for "change saved" message
  4. Leave dock settings
  5. Return to dock settings
  6. Observe value did not actually change

Expected behavior

The LED brightness should be saved, not just thrown away.

System version

1.6.7

What part of the system affected by the problem?

Web Configurator, Overall system

Additional context

No response

@spl237 spl237 added the bug Something isn't working label Jan 31, 2024
@github-actions github-actions bot added system System level issue web configurator Web configurator related issue labels Jan 31, 2024
@Quinterly
Copy link

Not fixed for me either.

@zehnm
Copy link

zehnm commented Feb 1, 2024

Confirmed: display issue in the web-configurator & remote-ui.
The new Brightness value is saved but the old value is displayed when the dialog is reopened.
Workaround for web-configurator: refresh the page.

@spl237
Copy link
Author

spl237 commented Feb 1, 2024

It's not just the displayed value which is wrong.

I cannot set the LED brightness to zero - nothing I have tried works. It always reverts to the previous value, and the LEDs keep coming on.

@Quinterly
Copy link

It's not just the displayed value which is wrong.

I cannot set the LED brightness to zero - nothing I have tried works. It always reverts to the previous value, and the LEDs keep coming on.

This is the issue. It's not the configurator, it's that the brightness is not controlled by the configuration.

@henrikwidlund
Copy link

It's not just the displayed value which is wrong.

I cannot set the LED brightness to zero - nothing I have tried works. It always reverts to the previous value, and the LEDs keep coming on.

For me it works from then web ui. Changing from the remote doesn't allow for setting to 0. Last time I tried it on the remote it displayed as 10% in the web ui after the change.

@zehnm
Copy link

zehnm commented Feb 6, 2024

This is the issue. It's not the configurator, it's that the brightness is not controlled by the configuration.

See #51. It's a "feature" that certain LED notifications are still shown. A "full-off" mode will be added.

Closing this ticket since the invalid dock brightness value in the web-configurator has been fixed in 1.6.9
The configuration in remote-ui will be fixed in a future update.

@zehnm zehnm closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working system System level issue web configurator Web configurator related issue
Projects
Status: Done
Development

No branches or pull requests

4 participants