Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UC_INTEGRATION_INTERFACE is an optional ENV var #2

Closed
zehnm opened this issue Oct 18, 2023 · 0 comments · Fixed by #5
Closed

UC_INTEGRATION_INTERFACE is an optional ENV var #2

zehnm opened this issue Oct 18, 2023 · 0 comments · Fixed by #5
Assignees
Labels
bug Something isn't working

Comments

@zehnm
Copy link
Contributor

zehnm commented Oct 18, 2023

The UC_INTEGRATION_INTERFACE environment variable is an optional setting to configure the listening interface.

Current behaviour is that if it is not set, the WebSocket listening doesn't work.

Expected: optional env var, if not set use 0.0.0.0

@zehnm zehnm added the bug Something isn't working label Oct 18, 2023
zehnm added a commit that referenced this issue Oct 29, 2023
Publish service with local hostname.
Cleanup interface and port handling.

Fixes #2
Fixes #3
@zehnm zehnm self-assigned this Oct 29, 2023
@zehnm zehnm closed this as completed in #5 Oct 31, 2023
zehnm added a commit that referenced this issue Oct 31, 2023
refactor: entity command handler on the base Entity
  This will simplify the client command handling significantly:
- configured entity is passed as argument
- basic error checking is done in the library
- websocket stays hidden
- command acknowledgment is implemented in the library

refactor: driver setup process
  Don't expose websocket or request ids. Setup flow is controlled by new data classes:
- Return object is the next step in the setup flow.
- The client should not have to know or call driver_setup_error, request_driver_setup_user_input, etc.

fix: mDNS service publishing
- Publish service with local hostname.
- Cleanup interface and port handling.

refactor: logging
- Remove logging.basicConfig() calls.
  Must be done by client.
- Make logging instances private.
- Move entity creation log statement to base class.

fix: improve websocket handling
- best effort in broadcast_ws_event
- add more type information
- add docstrings

fix: config_dir_path is always set
- Use ENV var UC_CONFIG_HOME for configuration directory, fallback to HOME directory or local path.

Prepare project for public release:
- add CONTRIBUTING.md
- add CHANGELOG.md
- add a minimal example
- enhance README

Closes #1
Fixes #2
Fixes #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant