Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Notes pages without verses break the extractor #435

Open
PurpleGuitar opened this issue Jan 6, 2016 · 5 comments
Open

Notes pages without verses break the extractor #435

PurpleGuitar opened this issue Jan 6, 2016 · 5 comments
Assignees

Comments

@PurpleGuitar
Copy link
Contributor

There's an unusual page for Luke chapter 0 (!!) in Door43:

https://door43.org/en/bible/notes/luk/00

The data extractor got confused because it couldn’t figure out what verse went with this reference.

We need to patch the extractor so that items like this don’t break it.

@PurpleGuitar
Copy link
Contributor Author

I spoke with Christine, and she explained that they're going to be creating more pages like this:

en/bible/notes/luke/00.txt - overview of book
en/bible/notes/luke/01/00.txt - overview of chapter

The second form is fine -- we'll start seeing verse 00 pop up in the dashboard.

The first form breaks the extractor because it doesn't know what verse is associated with this book.

I proposed that the extractor interprets it as verse 00, and Christine said that would be fine. We might consider using verse "(none)" as well. I'll talk to Tom.

@PurpleGuitar
Copy link
Contributor Author

Talked to Tom: verse is always numeric. So we'll go with verse 00.

@ChrisJarka
Copy link

I concur with Tom

@PurpleGuitar
Copy link
Contributor Author

Fix is in place, passed tests in TEST, now re-running the noontime job in PROD

@PurpleGuitar
Copy link
Contributor Author

PROD run completed successfully, data looks good, was successfully processed by DW importer

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants