-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of Build Process #2120
Conversation
… in appveyor and travis
after running
✔ Checking your system npm ERR! A complete log of this run can be found in: |
Reviewed 4 of 38 files at r1, 4 of 4 files at r3. package.json, line 24 at r3 (raw file):
do we want the code to point to your repo Comments from Reviewable |
Reviewed 29 of 38 files at r1, 1 of 1 files at r2. Comments from Reviewable |
@RoyalSix: I added a section in the documentation to follow for Electron-Forge installation. It covers deleting node_modules folder, installing e-f, npm install and you should be good. Comments from Reviewable |
@klappy I was thinking that maybe we need to test this branch in a Windows environment |
@mannycolon I have been testing on Windows concurrently. The build process isn't ready for Windows yet though. The PR is focused on Mac builds currently as well as my progress for Windows. Once we get this merged we can have builds for QA on Mac. |
Update from uW source develop fork/develop branch.
updated comment^^ |
@RoyalSix: Nice catch. I'm fixing that reference and any others I can find. |
@RoyalSix: Let me know if you find anything else. |
@RoyalSix @mannycolon: All issues are resolved and updated with latest develop branch. Is there anything else you need to merge this? Each time we merge into develop branch this process gets harder the longer we wait. |
This pull request addresses:
This PR addresses issues with the Build Process.
The build process is now lighter, less code, mostly a few config files.
How to test this pull request:
node_modules
folder from project.npm install
npm test
to make sure all tests still pass.npm start
to make sure app still starts and runs.npm make
on Mac to build the app.out/make
to ensure local build works.git status
to ensure the build was not destructive.If Questions aren't answered in documentation let me know so it can be updated: https://github.com/unfoldingWord-dev/translationCore/wiki/Distributing-tC:-Package-Build-Publish
This change is