Feature 7/add tn to md2html conversion #190
Conversation
TestTnPreprocessor - cleanup
|
Do not merge until develop is merged to master first, please. |
…o Feature_7/Add_tN_to_md2html_Conversion # Conflicts: # functions/convert_md2html/module.json # libraries/client/preprocessors.py # libraries/door43_tools/templaters.py # tests/converter_tests/test_md2html_converter.py # tests/door43_tools_tests/test_project_deployer.py # tests/integration_tests/test_conversion.py
|
Changes Unknown when pulling 0a04233 on PhotoNomad0:Feature_7/Add_tN_to_md2html_Conversion into ** on unfoldingWord-dev:develop**. |
…o Feature_7/Add_tN_to_md2html_Conversion # Conflicts: # libraries/converters/usfm2html_converter.py
…rge running at the same time. Improved some of the naming.
MarkdownLinter - fix paths to source files in warnings TestTnLinter - add markdown warnings
PhotoNomad0
changed the title
|
@richmahn - OK ready for review...again. |
| unzip(self.out_zip_file, self.out_dir) | ||
| remove(self.out_zip_file) | ||
|
|
||
| files_to_verify = ['00-toc.html', 'manifest.yaml', 'index.json'] |
There was a problem hiding this comment.
Shouldn't be verifying 00-toc.html exists as we don't want that file.
| return # skip test if integration test not enabled | ||
| git_url = "https://git.door43.org/tx-manager-test-data/en_tn.git" | ||
| base_url, repo, user = self.get_parts_of_git_url(git_url) | ||
| expected_output_name = ["00-toc"] + FULL_BIBLE_LIST |
There was a problem hiding this comment.
Shouldn't be verifying 00-toc.html exists as we don't want that file.
| files_to_verify = ['00-toc.html', 'manifest.yaml', 'index.json'] | ||
| for dir in BOOK_NUMBERS: | ||
| book = '{0}-{1}'.format(BOOK_NUMBERS[dir], dir.upper()) | ||
| file = '{0}.html'.format(book) |
There was a problem hiding this comment.
The reason file comes up even as orange here is its a reserved word in Python. Change to filename.
|
Deployed the latest of your branch to develop, registered modules, and set up and ran webhook for tx-manager-test-data/en_tn_nt, and found it is producing files for OT books, such as 01-GEN.html even though that isn't part of this (empty) (e.g. https://dev.door43.org/u/tx-manager-test-data/en_tn_nt/e48a154bbe/01-GEN.html), and index.html just shows that conversion is successful: https://dev.door43.org/u/tx-manager-test-data/en_tn_nt/e48a154bbe/ Also need the navigation to be like that of tQ's conversion (TqTemplater) |
|
@richmahn - yeah en_tn_nt needs to have the manifest fixed to remove the ot references. |
|
@richmahn - have navigation pane displayed now. Ready for review. |
Issue: unfoldingWord/door43.org#7
Example: http://test-door43.org.s3-website-us-west-2.amazonaws.com/u/tx-manager-test-data/en_tn/c9efc46e91/
Fixes for multipart race conditions, and updated comments to clarify multi part deploy stages.