This repository has been archived by the owner on May 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
Issue 511/update process documentation #62
Merged
richmahn
merged 4 commits into
unfoldingWord-dev:develop
from
PhotoNomad0:issue_511/update_process_documentation
May 11, 2017
Merged
Issue 511/update process documentation #62
richmahn
merged 4 commits into
unfoldingWord-dev:develop
from
PhotoNomad0:issue_511/update_process_documentation
May 11, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rst at end. README-tXArchitecture.rst - included data from https://github.com/unfoldingWord-dev/door43.org/wiki/tX-Development-Architecture#tx-manager-lambda-module and updated to separate out test and development environments.
richmahn
reviewed
May 9, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my glance over every section. I just noticed that maybe the section from the tx-manager-lambda repo's README.rst about how to deploy to the test service via apex should be included?
https://github.com/unfoldingWord-dev/tx-manager-lambda#deploying-your-branch-of-tx-manager-to-aws
@richmahn - Sounds good to me. Would a a hyperlink to tx-manager-lambda's documentation be sufficient? http://tx-manager-lambda.readthedocs.io/en/latest/readme.html |
…ct description to point to internal link.
richmahn
approved these changes
May 11, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue unfoldingWord/door43.org#511: update process documentation
Changes: