Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Feature/213 solidify badge statuses 2 #9

Merged
merged 16 commits into from
Jan 31, 2017
Merged

Feature/213 solidify badge statuses 2 #9

merged 16 commits into from
Jan 31, 2017

Conversation

PhotoNomad0
Copy link
Contributor

Related to issue: unfoldingWord/door43.org#213

Fixes:

  • Added unit tests for obs_handler, OBS Templater, TsObsMarkdownPreprocessor
  • Added a bunch of unit test data files for happy path and error conditions
  • Fixed TsObsMarkdownPreprocessor to sort chunks before merging into chapters.
  • Fixed Templater to not crash on conversion error.
  • Added versioning.

@PhotoNomad0
Fixed ordering of frames in chapter. Added a unit test for preprocessor.
9f2a8ef
@PhotoNomad0
Added failure case to unit test for preprocessor.
9d485df
@PhotoNomad0
Fix import for mock_utils.
3f22b0a
@PhotoNomad0
Fix to templater to gracefully recover if html file does not have a b…
c8037c7 
…ody. Added unit tests
@PhotoNomad0
Fix to templater to gracefully recover if html file contains XML (due…
4392cdd 
… to conversion error).
@PhotoNomad0
Fix to templater to gracefully recover if html file contains XML (due…
911d825 
… to conversion error). Organized unit test resource files. Added version numbers for required packages.
@PhotoNomad0
Organized unit test resource files.
d9e0fbd
@PhotoNomad0
Zipped up some unit test resource files.
9ecc0f1
@PhotoNomad0
Trying to fix bild error with mock package.
bbdfa02
@PhotoNomad0
Updated requests version to match version required on travis.
932c41a
@PhotoNomad0
Updated requests version to match version required on travis.
77bec62
@PhotoNomad0
Fix path to mock_utils to get to run on travis..
d1b2c38
@PhotoNomad0
Fix path to mock_utils to get to run on travis..
de6785a
@coveralls
Copy link

Coverage Status

Coverage increased (+26.9%) to 52.805% when pulling de6785a on PhotoNomad0:Feature/213_solidify_badge_statuses_2 into c62ca06 on unfoldingWord-dev:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+26.9%) to 52.805% when pulling 6844d42 on PhotoNomad0:Feature/213_solidify_badge_statuses_2 into c62ca06 on unfoldingWord-dev:develop.

phillip-hopper
phillip-hopper approved these changes Jan 31, 2017
View reviewed changes
Copy link
Contributor

@phillip-hopper phillip-hopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@phillip-hopper phillip-hopper merged commit 2af092b into unfoldingWord-dev:develop Jan 31, 2017
@PhotoNomad0 PhotoNomad0 deleted the Feature/213_solidify_badge_statuses_2 branch June 7, 2017 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@phillip-hopper phillip-hopper phillip-hopper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@PhotoNomad0 @coveralls @phillip-hopper