Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OBS Navigation For Mobile #564

Closed
jag3773 opened this issue Jun 1, 2017 · 4 comments
Closed

Add OBS Navigation For Mobile #564

jag3773 opened this issue Jun 1, 2017 · 4 comments
Assignees

Comments

@jag3773
Copy link
Contributor

jag3773 commented Jun 1, 2017

Story

As a mobile user I want to see the navigation pane so that view other chapters or stories.

Notes

Revisions sidebar should not be shown.

Here are some mockups of how navigation should work on mobile:

asset 1

asset 2

@richmahn
Copy link
Member

richmahn commented Jun 8, 2017

Are we also going to be able to see revisions? Is there an issue for that?

@phillip-hopper
Copy link
Contributor

I was not able to find enough good pages on live.door43.org to work on this at this time.

@phillip-hopper phillip-hopper removed their assignment Jun 10, 2017
@jag3773
Copy link
Contributor Author

jag3773 commented Jun 13, 2017

@jag3773 jag3773 changed the title Add Navigation For Mobile Add OBS Navigation For Mobile Jun 27, 2017
@benjore benjore added this to the WST Sprint #29 milestone Jun 30, 2017
@jag3773
Copy link
Contributor Author

jag3773 commented Jul 7, 2017

iphone obs 4x

@richmahn richmahn self-assigned this Jul 26, 2017
richmahn added a commit to richmahn/door43.org that referenced this issue Aug 1, 2017
richmahn added a commit to richmahn/door43.org that referenced this issue Aug 1, 2017
PhotoNomad0 pushed a commit that referenced this issue Aug 3, 2017
…650)

* Feature - Issue #564 - Adds mobile navigation for project pages

* Adds button with JS for mobile navigation toggle

* Makes sure right-sidebar-nav has the content-nav class

* Header removed from mobile view

* Fix scrollspy

* Makes use of whole page

* Fix to tA menu

* Adds left space to mobile menu

* Affix fixes
richmahn pushed a commit that referenced this issue Aug 4, 2017
* WIP: Feature - Issue #564 - Adds mobile navigation for project pages (#650)

* Feature - Issue #564 - Adds mobile navigation for project pages

* Adds button with JS for mobile navigation toggle

* Makes sure right-sidebar-nav has the content-nav class

* Header removed from mobile view

* Fix scrollspy

* Makes use of whole page

* Fix to tA menu

* Adds left space to mobile menu

* Affix fixes

* updated headers with logo split into graphic and text

* updated headers with logo split into graphic and text

* cleanup after merge conflict

* Fix text alignment.

* Fixed final image url.
Fux css for alignment of image.

* Tweaking logo text size and positioning.

* Fix click action.

* Fix click action for logo to not open new window.
PhotoNomad0 pushed a commit that referenced this issue Aug 8, 2017
* Feature - Issue #564 - Adds mobile navigation for project pages

* Adds button with JS for mobile navigation toggle

* Makes sure right-sidebar-nav has the content-nav class

* Header removed from mobile view

* Fix scrollspy

* Makes use of whole page

* Fix to tA menu

* Adds left space to mobile menu

* Affix fixes

* More work on the header

* Fix header padding

* Fixes to header

* Fix collapse and expand buttons

* Fix to test

* Fix to mock window width

* Fix for obs test fixture errors.

* Fix problem with download text not being set. (#7)

* More tests for mobile

* More coverage for mobile

* Tests for window resize for mobile

* Fixes for test

* Fixes for mobile test

* Fixes for mobile test

* Fixes for unit tests. (#8)
@jag3773 jag3773 closed this as completed Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants