Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tn and twl that they trigger scripture pane to show all verses in verse ranges/lists #376

Closed
birchamp opened this issue Mar 27, 2023 · 4 comments
Assignees

Comments

@birchamp
Copy link

birchamp commented Mar 27, 2023

The card and current item that is in focus determines what is shown in the scripture pane.

DoD:

When the user browses the TN or TWL card, the scripture pane updates what verse or verses are shown based on whether there is a reference range.

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Mar 27, 2023

Notes:

@Joel-C-Johnson
Copy link
Collaborator

test procedure

  • the fixes are in gatewayEdit in v1.2.0 build 9ebcb5b
  • test in unfoldingword org - en - PHP - 1:15
  • open tcCreate production - unfoldingword org - -tN- en - PHP - 1:15
  • edit the first note and change the reference to 1:14-18 and put some Greek words in the quote

screenShot 1
image

  • save the changes
  • open gatewayedit
  • select unfoldingword org - en - PHP - 1: 15 and you should see all the verses from 14 to 18 such as below.
    screenshot 2
    image

@elsylambert

@elsylambert
Copy link
Contributor

Looks good in v1.2.0 build 9ebcb5b

@danielklapp
Copy link

Looks good with v1.2.0 build 1f1cfb0 QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants