-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to add support for aligning chapter headers/front matter to GWE #559
Comments
@birchamp @elsylambert A few options here in handling error conditions when user clicks align:
It would probably be less confusing to user to do option 1 (my recommendation). And what message should we show on the error? |
I would suggest option 1. Case I: When the Scripture text do not have words to align, the message could be "There are no words to align in the Literal/Simplified Scripture Text" |
@birchamp @elsylambert It was suggested that when navigating by chapter or book that we default to verse 1 and not front. |
@elsylambert Merged the code into develop branch, but seeing a strange runtime bug when it shows an alignment error and use clicks cancel. Looking into it: |
@danielklapp ^^^ |
@kintsoogi I was able to narrow this down to being a crash in 'ta' resources. |
@elsylambert - This should be working in latest develop build |
Front matter support looks good in v2.1.0 build f845565 QA. By default the navigation is done to verse 1, but verse dropdown as Front option in the top. It enables users to align front matter. |
@PhotoNomad0 I wrote highlighting issue separately in #579. Highlighting is not working for front matter. |
I got the same results as stated above. Front matter support looks good to me and was tested with v2.1.0 build f845565 QA. |
Need to add support for aligning chapter headers/front matter to tCore. This is especially needed for Psalms alignment.
In Psalms there is chapter headers/front matter that is in the original language that needs to be aligned.
Not sure if any other book have this need.
This is directly related to unfoldingWord/translationCore#7536
DoD
Users can align scripture text under the \d marker.
The text was updated successfully, but these errors were encountered: