Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to add support for aligning chapter headers/front matter to GWE #559

Closed
PhotoNomad0 opened this issue Oct 12, 2023 · 11 comments
Closed
Assignees
Labels

Comments

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Oct 12, 2023

Need to add support for aligning chapter headers/front matter to tCore. This is especially needed for Psalms alignment.

In Psalms there is chapter headers/front matter that is in the original language that needs to be aligned.

Not sure if any other book have this need.

This is directly related to unfoldingWord/translationCore#7536

DoD

Users can align scripture text under the \d marker.

@PhotoNomad0 PhotoNomad0 changed the title Need to add support for aligning chapter front matter to GWE Need to add support for aligning chapter headers/front matter to GWE Oct 12, 2023
@birchamp birchamp added enhancement New feature or request Priority/High labels Oct 18, 2023
@PhotoNomad0 PhotoNomad0 self-assigned this Oct 19, 2023
@PhotoNomad0
Copy link
Contributor Author

PhotoNomad0 commented Oct 19, 2023

@birchamp @elsylambert A few options here in handling error conditions when user clicks align:

  1. we can add separate warning dialogs:
  • There are no align-able words in the target language
  • There are no align-able words in the original language
  1. we can add single warning dialog for when either target language or original language does not have align-able words

It would probably be less confusing to user to do option 1 (my recommendation).

And what message should we show on the error?

@PhotoNomad0 PhotoNomad0 added the question Further information is requested label Oct 19, 2023
@elsylambert
Copy link
Contributor

I would suggest option 1.

Case I: When the Scripture text do not have words to align, the message could be "There are no words to align in the Literal/Simplified Scripture Text"
Case II: When Original language does not have words to align, the message could be "There are no words to align in the Original language"

@PhotoNomad0
Copy link
Contributor Author

@birchamp @elsylambert It was suggested that when navigating by chapter or book that we default to verse 1 and not front.

@PhotoNomad0
Copy link
Contributor Author

@elsylambert Merged the code into develop branch, but seeing a strange runtime bug when it shows an alignment error and use clicks cancel. Looking into it:
Screenshot 2023-11-01 at 1 20 52 PM

@PhotoNomad0
Copy link
Contributor Author

@danielklapp ^^^

@PhotoNomad0
Copy link
Contributor Author

I was able to reproduce this in a debug build of the develop branch. I see a clue as to what is going on:
Screenshot 2023-11-01 at 3 38 18 PM

@PhotoNomad0
Copy link
Contributor Author

@kintsoogi I was able to narrow this down to being a crash in 'ta' resources.

@PhotoNomad0
Copy link
Contributor Author

@elsylambert - This should be working in latest develop build

@elsylambert
Copy link
Contributor

Front matter support looks good in v2.1.0 build f845565 QA. By default the navigation is done to verse 1, but verse dropdown as Front option in the top. It enables users to align front matter.
Private Zenhub Image

Private Zenhub Image

@elsylambert
Copy link
Contributor

@PhotoNomad0 I wrote highlighting issue separately in #579. Highlighting is not working for front matter.

@danielklapp
Copy link

I got the same results as stated above. Front matter support looks good to me and was tested with v2.1.0 build f845565 QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants