Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting is skipping words with greek's elision marks #179

Open
abelpz opened this issue Oct 31, 2023 · 2 comments · Fixed by #180 or unfoldingWord/tc-create-app#1627
Open

Highlighting is skipping words with greek's elision marks #179

abelpz opened this issue Oct 31, 2023 · 2 comments · Fixed by #180 or unfoldingWord/tc-create-app#1627
Assignees
Labels
bug Something isn't working QA/Passed

Comments

@abelpz
Copy link
Member

abelpz commented Oct 31, 2023

Message from Stepheh in Zulip:

I'd like to revisit the highlighting problems in tCC and GE whenever the Quote field in a TN includes a Greek word with an elision marks. This is causing serious difficulties for our proofreaders, which means it will cause the same difficulties for end users. For example, here's a section of the proofreading spreadsheet:
image
Every single one of these rows is a place where the highlighting is incorrect because tCC and GE are not recognizing the Greek words with elision marks. Here's an example of what it looks like in tCC:
image (1)
I've included every Greek word in the Quote field, but every word with an elision mark fails to highlight. How is the program recognizing words in the UGNT based on the Quote field? Is it stripping out punctuation when it looks for a matching string of characters?
Fixing this issue will make the resources much more useable, so I appreciate any help.

@danielklapp
Copy link

No missing highlights for words with greek's elision marks. Looks good to me. Tested with translationCore Create - v1.15.1 build 272-73d6093.

@elsylambert
Copy link

elsylambert commented Dec 4, 2023

Looks good in GWE in v2.2.0 build 3179311 QA. Highlights for Greek elision marks works fine.

Screenshot 2023-12-04 at 5.20.01 PM.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA/Passed
Projects
None yet
4 participants