Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview takes the page to Page 1 when filter is on. #162

Closed
elsylambert opened this issue Jun 18, 2020 · 4 comments
Closed

Preview takes the page to Page 1 when filter is on. #162

elsylambert opened this issue Jun 18, 2020 · 4 comments
Assignees
@RoyalSix
Labels
bug Something isn't working demoed this issue was demonstrated during a review. QA/Passed QA Completed

Comments

@elsylambert
Copy link
Contributor

elsylambert commented Jun 18, 2020 •
edited by BincyJ
Loading

Steps to replicate:

  • Select the filter in UTN to go to chapter 2 or 3 of the book.
  • Click on the Preview button.
  • It lands on the first page/chapter of the book.

DoD: On clicking the preview button, the window should direct to the preview of the selected book and chapter.( same location as filter)
@elsylambert elsylambert added the bug Something isn't working label Jun 18, 2020
@birchamp
Copy link
Contributor

birchamp commented Jul 1, 2020

make lightweight context consumer for the preview to avoid prop drilling that causes the re-render.

@RoyalSix RoyalSix self-assigned this Jul 13, 2020
@ancientTexts-net
Copy link
Contributor

Testable in app in v1.0.0-beta.10

https://deploy-preview-204--tc-create-app.netlify.app/

@elsylambert
Copy link
Contributor Author

Looks good at https://deploy-preview-204--tc-create-app.netlify.app/ in version 1.0.0-beta.10. Preview works fine when the filter is ON.

@elsylambert elsylambert added the QA/Passed QA Completed label Jul 16, 2020
@elsylambert
Copy link
Contributor Author

Looks good in version 1.0.0-beta.10.

@birchamp birchamp added the demoed this issue was demonstrated during a review. label Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RoyalSix RoyalSix

Labels
bug Something isn't working demoed this issue was demonstrated during a review. QA/Passed QA Completed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@birchamp @RoyalSix @elsylambert @ancientTexts-net