Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge latest develop #7565

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Merge latest develop #7565

merged 1 commit into from
Mar 9, 2024

Conversation

PhotoNomad0
Copy link
Contributor

Describe what your pull request addresses (Please include relevant issue numbers):

Please include detailed Test instructions for your pull request:

Standard Test Instructions for PR Review Process:

  • Double check unit tests that have been written
  • Check for documentation for code changes
  • Check that there are not inadvertent commits to tC Apps when reviewing a tC Core PR
  • Checkout the branch locally and ensure that app runs as expected
    • Ensure tests pass
    • Open and watch the console for errors
    • Make sure all actions perform as expected
    • Import and Load a new Project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Switch project to an existing project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Next time reverse the order of importing after loading an existing project
  • Reviewer should double check the DoD in the ISSUE, including the “spirit” of the story
  • Ask Ben or Koz if you have any concerns about implementation (especially UI related)

Co-authored-by: PhotoNomad0 <bruce.mclean@unfoldingword.org>
@PhotoNomad0 PhotoNomad0 merged commit ef72f01 into release-v3.6.3 Mar 9, 2024
3 of 5 checks passed
@delete-merged-branch delete-merged-branch bot deleted the merge-latest branch March 9, 2024 19:22
PhotoNomad0 added a commit that referenced this pull request Mar 11, 2024
* add fixes for invalid localization (#7564) (#7565)

Co-authored-by: PhotoNomad0 <bruce.mclean@unfoldingword.org>

* add fixes for tn import and migration errors

* add fixes for tn import

---------

Co-authored-by: PhotoNomad0 <bruce.mclean@unfoldingword.org>
PhotoNomad0 added a commit that referenced this pull request Mar 11, 2024
* add fixes for invalid localization (#7564)

Co-authored-by: PhotoNomad0 <bruce.mclean@unfoldingword.org>

* Bugfix / fix tn import (#7566)

* add fixes for invalid localization (#7564) (#7565)

Co-authored-by: PhotoNomad0 <bruce.mclean@unfoldingword.org>

* add fixes for tn import and migration errors

* add fixes for tn import

---------

Co-authored-by: PhotoNomad0 <bruce.mclean@unfoldingword.org>

---------

Co-authored-by: PhotoNomad0 <bruce.mclean@unfoldingword.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant