Conversation
Correct the summary link to Contribution Guidelines subsection. Close #69. [skip ci]
I did a second commit, because my Prettier config has changed some double quotes at the code blocks. Now everything is correct again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that there are some changes that weren't reverted in your last commit. Commit the full revert and we are ready to merge! 😄
--- (optional)
You could also add the remaining changes in your last commit using: git commit --amend --no-edit
and git push -f
And, if you want to go a step further, use git rebase -i
on your branch
to squash the reverting commit onto the first commit.
I'm facing some problems with VSCode, most specifc, Prettier is somehow taking out all the semicolons that I add at the end of a function. I have deleted all Prettier configs in settings.json, but the problem still. Do you know how can I correct that? I have ESLint and Prettier correctly installed to VSCode and the only configuration regarding Prettier in my settings.json are the following:
Anyone knows what can I do to avoid that? |
@Ruttmann Try merging our master branch to you fork and try again. We made some changes to prettier and eslint. |
I've made a new commit. Can you please verify if everything is ok now? |
Fixing conflicts on this branch, I ended up realizing that a PR (#35) that was merged earlier today solved this. Sorry about that, we are grateful for your contribution. ❤️ |
Correct the summary link to Contribution Guidelines subsection.
Close #69. [skip ci]
Changes proposed
Just corrected the line 68 of the README.md file, according to my comment on issue #69
From:
- [Contribution Guidelines](#contributing-guide)
To:
- [Contribution Guidelines](#contribution-guidelines)