This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
chore: Fix prettier integration #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prettier recommended settings were overriding some of AirBnB style guide rules. Removed prettier recommended rules.
pellizzetti
approved these changes
May 22, 2019
pellizzetti
added a commit
that referenced
this pull request
May 22, 2019
Makes README follow the ajusts regarding coding style that PR #71 brought.
pellizzetti
added a commit
that referenced
this pull request
May 22, 2019
Makes README follow the ajusts regarding coding style that PR #71 brought. [skip ci]
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed
Remove Prettier recommended rules from ESLint.
Additional context
Prettier recommended settings were overriding some of AirBnB style guide rules.
Example: AirBnB points that quotes must be single, and with Prettier recommended rules we are using double quotes.