Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for object_type before creating object_slug #44

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+13 −1
Open

Check for object_type before creating object_slug #44

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ba0ed8
Check for object_type before creating object_slug
nine-2-five Jun 3, 2017
43940fc
refactor getting object slug into function
nine-2-five Jun 11, 2017
60be1fa
fix for taxonomy slugs
nine-2-five Aug 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 13 additions & 1 deletion includes/wp-api-menus-v2.php
View file
Open in desktop
Expand Up @@ -383,7 +383,7 @@ public function format_menu_item( $menu_item, $children = false, $menu = array()
'description' => $item['description'],
'object_id' => abs( $item['object_id'] ),
'object' => $item['object'],
'object_slug' => get_post( $item['object_id'] )->post_name,
'object_slug' => $this->get_object_slug( $item ),
'type' => $item['type'],
'type_label' => $item['type_label'],
);
Expand All @@ -395,6 +395,18 @@ public function format_menu_item( $menu_item, $children = false, $menu = array()
return apply_filters( 'rest_menus_format_menu_item', $menu_item );
}

private function get_object_slug($item){
$slug = '';

if($item['type'] == 'taxonomy'){
$slug = get_term( $item['object_id'] )->slug;
}
else {
$slug = get_post( $item['object_id'] )->post_name;
}

return $slug;
}

}

Expand Down