Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[github-auth] accept API token instead of user/pass #5

Closed
ungoldman opened this issue Feb 28, 2015 · 5 comments
Closed

[github-auth] accept API token instead of user/pass #5

ungoldman opened this issue Feb 28, 2015 · 5 comments

Comments

@ungoldman
Copy link
Owner

No description provided.

@ungoldman
Copy link
Owner Author

@bcomnes do you think https://github.com/rvagg/ghauth will do the trick? might also mean gh-release wouldn't need to rely on the github package.

bcomnes added a commit to bcomnes/gh-release that referenced this issue Mar 2, 2015
Passwords are stored in ~/.config/gh-release.json

Closes ungoldman#5
bcomnes added a commit to bcomnes/gh-release that referenced this issue Mar 2, 2015
Passwords are stored in ~/.config/gh-release.json

Closes ungoldman#5
@bcomnes
Copy link
Collaborator

bcomnes commented Mar 2, 2015

Uh oh, getting errors on the head of auth now (cf511ed):

Bret-MBR:gh-release-test bret$ gh-release 
{ tag_name: 'v1.0.1',
  target_commitish: '40c8e8708a315a00b7673eabbc27a83438305c10',
  name: 'v1.0.1',
  body: '* Made another release\n\n',
  owner: 'bcomnes',
  repo: 'gh-release-test',
  draft: false,
  prerelease: false }
? does this look right? Yes
{ [Error: {"message":"Server Error","documentation_url":"https://developer.github.com/v3"}]
  message: '{"message":"Server Error","documentation_url":"https://developer.github.com/v3"}',
  code: 500 }

Woops forgot to push!

@bcomnes
Copy link
Collaborator

bcomnes commented Mar 2, 2015

Looks ready to merge to master to me if your cool with that.

@ungoldman
Copy link
Owner Author

@bcomnes I'm still doing a little work on auth -- I'll open a PR in a little bit.

@ungoldman
Copy link
Owner Author

@bcomnes I ran into the 500 error from github too when forgetting to push for https://github.com/bcomnes/gh-release-test -- note to self to check if the commit being released is on github first then display a better error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants