allow unreleased CHANGELOG section if all subsections are empty #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgravois
reviewed
May 6, 2021
There was a problem hiding this comment.
thanks for this contribution @leviathan747! i think its a handy change and the code comment below seems to indicate that you're implementing the intended behavior.
if you can add another fixture and test, we should be able to get this PR landed.
|
@jgravois ready for final review Quick question: what's the release schedule of this project? When could I expect to see this change in a release version? |
jgravois
approved these changes
May 18, 2021
There was a problem hiding this comment.
i added one more test in 20b9a8e. thanks again @leviathan747!
if i have the 🔑s, i'll publish this as a patch forthwith.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My team likes to keep the 6 subsection headings from keepachangelog in
CHANGELOG.mdthat way we don't have to remember the categories. This change only prevents the release if there are any bullets in any of the subsections.