Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 0.83.0 to 0.84.0 #169

Merged
merged 1 commit into from
May 23, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps rubocop from 0.83.0 to 0.84.0.

Release notes

Sourced from rubocop's releases.

RuboCop 0.84

New features

  • #7735: NodePattern and AST classes have been moved to the rubocop-ast gem. (@marcandre)
  • #7950: Add new Lint/DeprecatedOpenSSLConstant cop. (@bdewater)
  • #7976: Add AllowAliasSyntax and AllowedMethods options for Layout/EmptyLinesAroundAttributeAccessor. (@koic)
  • #7984: New rake task "check_commit" will run rspec and rubocop on files touched by the last commit. (@marcandre)

Bug fixes

  • #7953: Fix an error for Lint/AmbiguousOperator when a method with no arguments is used in advance. (@koic)
  • #7962: Fix a false positive for Lint/ParenthesesAsGroupedExpression when heredoc has a space between the same string as the method name and (. (@koic)
  • #7967: Style/SlicingWithRange cop now supports any expression as its first index. (@zverok)
  • #7972: Fix an incorrect autocrrect for Style/HashSyntax when using a return value uses return. (@koic)
  • #7886: Fix a bug in AllowComments logic in Lint/SuppressedException. (@jonas054)
  • #7991: Fix an error for Layout/EmptyLinesAroundAttributeAccessor when attribute method is method chained. (@koic)
  • #7993: Fix a false positive for Migration/DepartmentName when a disable comment contains an unexpected character for department name. (@koic)

Changes

  • #7952: (Breaking) Change the max line length of Layout/LineLength to 120 by default. (@koic)
  • #7959: Change enforced style to conditionals for Style/AndOr. (@koic)
  • #7985: Add EnforcedStyle for Style/DoubleNegation cop and allow double nagation in contexts that use boolean as a return value. (@koic)
Changelog

Sourced from rubocop's changelog.

0.84.0 (2020-05-21)

New features

  • #7735: NodePattern and AST classes have been moved to the rubocop-ast gem. ([@marcandre][])
  • #7950: Add new Lint/DeprecatedOpenSSLConstant cop. ([@bdewater][])
  • #7976: Add AllowAliasSyntax and AllowedMethods options for Layout/EmptyLinesAroundAttributeAccessor. ([@koic][])
  • #7984: New rake task "check_commit" will run rspec and rubocop on files touched by the last commit. Currently available when developing from the main repository only. ([@marcandre][])

Bug fixes

  • #7953: Fix an error for Lint/AmbiguousOperator when a method with no arguments is used in advance. ([@koic][])
  • #7962: Fix a false positive for Lint/ParenthesesAsGroupedExpression when heredoc has a space between the same string as the method name and (. ([@koic][])
  • #7967: Style/SlicingWithRange cop now supports any expression as its first index. ([@zverok][])
  • #7972: Fix an incorrect autocrrect for Style/HashSyntax when using a return value uses return. ([@koic][])
  • #7886: Fix a bug in AllowComments logic in Lint/SuppressedException. ([@jonas054][])
  • #7991: Fix an error for Layout/EmptyLinesAroundAttributeAccessor when attribute method is method chained. ([@koic][])
  • #7993: Fix a false positive for Migration/DepartmentName when a disable comment contains an unexpected character for department name. ([@koic][])

Changes

  • #7952: (Breaking) Change the max line length of Layout/LineLength to 120 by default. ([@koic][])
  • #7959: Change enforced style to conditionals for Style/AndOr. ([@koic][])
  • #7985: Add EnforcedStyle for Style/DoubleNegation cop and allow double nagation in contexts that use boolean as a return value. ([@koic][])
Commits
  • 10a6f91 Fix the release notes
  • d7bfd36 Cut 0.84
  • 119d695 Add doc for disabling comment style
  • 82ded12 [Fix #7993] Fix a false positive for Migration/DepartmentName
  • 2a57489 Add a .dir-locals.el
  • c7fe5da Remove unneeded let for specs using :config shared environment
  • 3c91822 Refactor config shared context. Simplify some specs.
  • 4d694e3 Spec: remove trailing whitespace
  • 2e8f013 Lint/SuppressedException: Explicit AllowComments config in spec
  • 36d3e30 Lint/EmptyWhen Add explicit config that is differing from default #7999
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.83.0 to 0.84.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v0.83.0...v0.84.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label May 22, 2020
@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #169 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #169   +/-   ##
=======================================
  Coverage   74.67%   74.67%           
=======================================
  Files          25       25           
  Lines         541      541           
=======================================
  Hits          404      404           
  Misses        137      137           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e49dd7f...ffa5237. Read the comment docs.

@unhappychoice unhappychoice merged commit e48f86b into master May 23, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/rubocop-0.84.0 branch May 23, 2020 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant