subprocess call should check return status

[caodg]

not just calling sys_run and assume it will execute correctly. sometimes it will fail and the failure info will get lost.

[zhongyehong]

I have checked returncode after calling sys_run, the bug today is i call (lxc-stop -k -n %s) but not ((lxc-stop -k -n %s) % lxc_name). So the shell regard "%s" as lxc_name. I have checked the returncode after calling this, but the calling is a "grep RUNNING". It return not 0, the same with a stopped container. Docklet misakes it for a stopped container. It is not because that I call sys_run without checking returncode.

[caodg]

you mean checking like this?

 if status == "running":
        sys_run("lxc-stop -k -n %s" % lxc_name)
[success, status] = self.container_status(lxc_name)

should be

Ret = sys_run(...)
if Ret.returncode == 0:

I recommend not encapsulating sys call in sys_run, you can directly call subprocess.run with check=True, or we do not need to using this python 3.5 new api.

[zhongyehong]

Done