Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validating a repository without a license leads to an internal error and no result #8

Closed
Tobias-TH opened this issue Oct 16, 2023 · 0 comments · Fixed by #9
Closed
Assignees
Labels
bug Something isn't working

Comments

@Tobias-TH
Copy link
Collaborator

The validation of (public and private) repositories without a license file returns no results in the frontend. Instead, the spinner in the grey result button contiunes to spin.
At the same time, the terminal where Docker Compose is running, shows this error message (here shortened):

File "/src/shacl_validator.py", line 104, in create_repository_representation
license = repo.get_license()
. . .
github.GithubException.UnknownObjectException: 404 {"message": "Not Found", "documentation_url": "https://docs.github.com/rest/licenses/licenses#get-the-license-for-a-repository"}

@Tobias-TH Tobias-TH added the bug Something isn't working label Oct 16, 2023
@Tobias-TH Tobias-TH self-assigned this Oct 16, 2023
Tobias-TH added a commit that referenced this issue Oct 16, 2023
Fix #8 by adding error handling to license retrieval
@Tobias-TH Tobias-TH linked a pull request Oct 16, 2023 that will close this issue
leonmartin added a commit that referenced this issue Jan 15, 2024
* added branch dev

* finished license paragraph in readme

* improved logging

* removed obsolete token

* optimized docker configuration

* fixed docker config

* fixed issues with docker compose (issue #3)

* refactored navigation

* styling improvements

* package update

* fixed bug in OWL approach

* prepared interface for verbalization

* removed unnecessary code

* added fair project type

* simplified access to stores; form simplification; navbar improvements

* migrated from rollup to vite

* updated docker config

* jsconfig fix

* updated .gitignore

* ui and code improvments

* mode is now also stored in localStorage

* restructured frontend

* restructured frontend

* improved componentization + refactoring

* minor

* Fix #8 by adding error handling to license retrieval

* Implement FAIR Project Type for Validation (#27)

* Add comments to existing SHACL project shapes #11

* Temporarily fix error when there is no result path #15

* Model FAIR principles as SHACL rules #11

* Fix semantic versioning regex

* Use match-case syntax #20

* Switch from short SHACL notation to more verbose one

* For files, make check in root directory explicit

* Extract the sh:or and sh:and components into node shapes

* Extend repository representation with homepage, tags, and DOIs in readme

* Introduce property shapes

* Split the shapes graph into several files.

* Fix selection and display of project types

* Extend repository representation for FAIR type (#13)

* Add check for valid version increment to repository representation (#13)

* Create separate methods for each repository property (#22)

* Limit repository representation to requirements of project type (#22)

* Remove unnecessary graph returns and process description literal earlier (#22)

* Make check for valid version increment less strict (#13)

* Visualize repository representation ontology (#21)

* Fix cut off letters at the end of words in diagram (#21)

* Adapt verbalized explanation for FAIR project type (#15)

* For sh:or,and,xone: use source shape instead of message (#15)

* Add URLs of IRIs in README.md (#21)

* Replace <repo> "has_default_branch" with <branch> "is_default_branch" (#13, #21, #22)

* Add minCount to qualifiedValueShapes (#11)

Previously, qualifiedValueShape only included qualifiedMinCount. This meant that a graph was valid in which the specified path did not exist at all.

* Add missing minCount constraints (#11)

* Adapt property shapes to changed default branch representation (#11)

* Include number of violations in validation response (#19)

* Show share of fulfilled criteria, v1 (#19)

* Adjust button of progress bar (#19)

* Adapt checks for files in root directory of default branch (#11)

* Use properties from the Software Description Ontology (#24)

* Integration tests for validation of FAIR project type, part 1 (#18)

* Use camelCase for own properties (as in SDO) (#24)

* Replace "has_section" property with more specific ones from SDO (#24)

* Integration tests for validation of FAIR project type, part 2 (#18)

* Introduce mocking (#18)

* Remove OWL part (#25)

* Fix ZeroDivisionError in benchmark.py (#26)

* Adapt FAIR criteria as a result of tests with 26 repos (#14)

* Remove "using" as keyword for usage documentation because of false positives (#14)

---------

Co-authored-by: Leon Martin <Leon@Home>
Co-authored-by: lema <leon_martin@t-online.de>
Co-authored-by: Leon Martin <lema@work>
leonmartin added a commit that referenced this issue Feb 5, 2024
* added branch dev

* finished license paragraph in readme

* improved logging

* removed obsolete token

* optimized docker configuration

* fixed docker config

* fixed issues with docker compose (issue #3)

* refactored navigation

* styling improvements

* package update

* fixed bug in OWL approach

* prepared interface for verbalization

* removed unnecessary code

* added fair project type

* simplified access to stores; form simplification; navbar improvements

* migrated from rollup to vite

* updated docker config

* jsconfig fix

* updated .gitignore

* ui and code improvments

* mode is now also stored in localStorage

* restructured frontend

* restructured frontend

* improved componentization + refactoring

* minor

* Fix #8 by adding error handling to license retrieval

* Implement FAIR Project Type for Validation (#27)

* Add comments to existing SHACL project shapes #11

* Temporarily fix error when there is no result path #15

* Model FAIR principles as SHACL rules #11

* Fix semantic versioning regex

* Use match-case syntax #20

* Switch from short SHACL notation to more verbose one

* For files, make check in root directory explicit

* Extract the sh:or and sh:and components into node shapes

* Extend repository representation with homepage, tags, and DOIs in readme

* Introduce property shapes

* Split the shapes graph into several files.

* Fix selection and display of project types

* Extend repository representation for FAIR type (#13)

* Add check for valid version increment to repository representation (#13)

* Create separate methods for each repository property (#22)

* Limit repository representation to requirements of project type (#22)

* Remove unnecessary graph returns and process description literal earlier (#22)

* Make check for valid version increment less strict (#13)

* Visualize repository representation ontology (#21)

* Fix cut off letters at the end of words in diagram (#21)

* Adapt verbalized explanation for FAIR project type (#15)

* For sh:or,and,xone: use source shape instead of message (#15)

* Add URLs of IRIs in README.md (#21)

* Replace <repo> "has_default_branch" with <branch> "is_default_branch" (#13, #21, #22)

* Add minCount to qualifiedValueShapes (#11)

Previously, qualifiedValueShape only included qualifiedMinCount. This meant that a graph was valid in which the specified path did not exist at all.

* Add missing minCount constraints (#11)

* Adapt property shapes to changed default branch representation (#11)

* Include number of violations in validation response (#19)

* Show share of fulfilled criteria, v1 (#19)

* Adjust button of progress bar (#19)

* Adapt checks for files in root directory of default branch (#11)

* Use properties from the Software Description Ontology (#24)

* Integration tests for validation of FAIR project type, part 1 (#18)

* Use camelCase for own properties (as in SDO) (#24)

* Replace "has_section" property with more specific ones from SDO (#24)

* Integration tests for validation of FAIR project type, part 2 (#18)

* Introduce mocking (#18)

* Remove OWL part (#25)

* Fix ZeroDivisionError in benchmark.py (#26)

* Adapt FAIR criteria as a result of tests with 26 repos (#14)

* Remove "using" as keyword for usage documentation because of false positives (#14)

* Recognize all keywords per heading (#31) (#33)

* Improve verbalization on validation and specification page (#34)

* Add sh:message to node- and property-shapes (#29)

* Use messages from the validation report in verbalization (#29)

* Add sh:message to node- and property-shapes (#29)

* Use messages from the validation report in verbalization (#29)

* Make check for open issues more precise

* Display verbalized explanation as an unordered list (#29)

* Extract quality criteria from the shapes graph via RDFLib (#30)

* Add descriptions to the node- and property shapes (#30)

* Use Markdown to format descriptions (#30)

* Use adapted Markdown renderer (#30)

* Update Node and package versions

* Add information about SW requirements and citation to README.md

* Organize quality criteria in Markdown tables (#30)

* Correct cardinality in README.md

---------

Co-authored-by: Leon Martin <Leon@Home>
Co-authored-by: lema <leon_martin@t-online.de>
Co-authored-by: Leon Martin <lema@work>
leonmartin added a commit that referenced this issue Apr 17, 2024
* added branch dev

* finished license paragraph in readme

* improved logging

* removed obsolete token

* optimized docker configuration

* fixed docker config

* fixed issues with docker compose (issue #3)

* refactored navigation

* styling improvements

* package update

* fixed bug in OWL approach

* prepared interface for verbalization

* removed unnecessary code

* added fair project type

* simplified access to stores; form simplification; navbar improvements

* migrated from rollup to vite

* updated docker config

* jsconfig fix

* updated .gitignore

* ui and code improvments

* mode is now also stored in localStorage

* restructured frontend

* restructured frontend

* improved componentization + refactoring

* minor

* Fix #8 by adding error handling to license retrieval

* Implement FAIR Project Type for Validation (#27)

* Add comments to existing SHACL project shapes #11

* Temporarily fix error when there is no result path #15

* Model FAIR principles as SHACL rules #11

* Fix semantic versioning regex

* Use match-case syntax #20

* Switch from short SHACL notation to more verbose one

* For files, make check in root directory explicit

* Extract the sh:or and sh:and components into node shapes

* Extend repository representation with homepage, tags, and DOIs in readme

* Introduce property shapes

* Split the shapes graph into several files.

* Fix selection and display of project types

* Extend repository representation for FAIR type (#13)

* Add check for valid version increment to repository representation (#13)

* Create separate methods for each repository property (#22)

* Limit repository representation to requirements of project type (#22)

* Remove unnecessary graph returns and process description literal earlier (#22)

* Make check for valid version increment less strict (#13)

* Visualize repository representation ontology (#21)

* Fix cut off letters at the end of words in diagram (#21)

* Adapt verbalized explanation for FAIR project type (#15)

* For sh:or,and,xone: use source shape instead of message (#15)

* Add URLs of IRIs in README.md (#21)

* Replace <repo> "has_default_branch" with <branch> "is_default_branch" (#13, #21, #22)

* Add minCount to qualifiedValueShapes (#11)

Previously, qualifiedValueShape only included qualifiedMinCount. This meant that a graph was valid in which the specified path did not exist at all.

* Add missing minCount constraints (#11)

* Adapt property shapes to changed default branch representation (#11)

* Include number of violations in validation response (#19)

* Show share of fulfilled criteria, v1 (#19)

* Adjust button of progress bar (#19)

* Adapt checks for files in root directory of default branch (#11)

* Use properties from the Software Description Ontology (#24)

* Integration tests for validation of FAIR project type, part 1 (#18)

* Use camelCase for own properties (as in SDO) (#24)

* Replace "has_section" property with more specific ones from SDO (#24)

* Integration tests for validation of FAIR project type, part 2 (#18)

* Introduce mocking (#18)

* Remove OWL part (#25)

* Fix ZeroDivisionError in benchmark.py (#26)

* Adapt FAIR criteria as a result of tests with 26 repos (#14)

* Remove "using" as keyword for usage documentation because of false positives (#14)

* Recognize all keywords per heading (#31) (#33)

* Improve verbalization on validation and specification page (#34)

* Add sh:message to node- and property-shapes (#29)

* Use messages from the validation report in verbalization (#29)

* Add sh:message to node- and property-shapes (#29)

* Use messages from the validation report in verbalization (#29)

* Make check for open issues more precise

* Display verbalized explanation as an unordered list (#29)

* Extract quality criteria from the shapes graph via RDFLib (#30)

* Add descriptions to the node- and property shapes (#30)

* Use Markdown to format descriptions (#30)

* Use adapted Markdown renderer (#30)

* Update Node and package versions

* Add information about SW requirements and citation to README.md

* Organize quality criteria in Markdown tables (#30)

* Correct cardinality in README.md

* Include lower-case letters in the DOI regex

* Add code and resulting files of the quantitative evaluation.

* Add information on how to execute the quantitative evaluation

* benchmark fusion

* change benchmark to scatterplot

* tests with scatter plot

* reran benchmark

* refactored evaluation

* refactored evaluation

* formatting benchmark results

* cleanup

* statistical analysis of runtime benchmark results

* updated benchmark figures

---------

Co-authored-by: Leon Martin <Leon@Home>
Co-authored-by: Leon Martin <lema@work>
Co-authored-by: Tobias Hummel <71486844+Tobias-TH@users.noreply.github.com>
leonmartin added a commit that referenced this issue May 13, 2024
* added branch dev

* finished license paragraph in readme

* improved logging

* removed obsolete token

* optimized docker configuration

* fixed docker config

* fixed issues with docker compose (issue #3)

* refactored navigation

* styling improvements

* package update

* fixed bug in OWL approach

* prepared interface for verbalization

* removed unnecessary code

* added fair project type

* simplified access to stores; form simplification; navbar improvements

* migrated from rollup to vite

* updated docker config

* jsconfig fix

* updated .gitignore

* ui and code improvments

* mode is now also stored in localStorage

* restructured frontend

* restructured frontend

* improved componentization + refactoring

* minor

* Fix #8 by adding error handling to license retrieval

* Implement FAIR Project Type for Validation (#27)

* Add comments to existing SHACL project shapes #11

* Temporarily fix error when there is no result path #15

* Model FAIR principles as SHACL rules #11

* Fix semantic versioning regex

* Use match-case syntax #20

* Switch from short SHACL notation to more verbose one

* For files, make check in root directory explicit

* Extract the sh:or and sh:and components into node shapes

* Extend repository representation with homepage, tags, and DOIs in readme

* Introduce property shapes

* Split the shapes graph into several files.

* Fix selection and display of project types

* Extend repository representation for FAIR type (#13)

* Add check for valid version increment to repository representation (#13)

* Create separate methods for each repository property (#22)

* Limit repository representation to requirements of project type (#22)

* Remove unnecessary graph returns and process description literal earlier (#22)

* Make check for valid version increment less strict (#13)

* Visualize repository representation ontology (#21)

* Fix cut off letters at the end of words in diagram (#21)

* Adapt verbalized explanation for FAIR project type (#15)

* For sh:or,and,xone: use source shape instead of message (#15)

* Add URLs of IRIs in README.md (#21)

* Replace <repo> "has_default_branch" with <branch> "is_default_branch" (#13, #21, #22)

* Add minCount to qualifiedValueShapes (#11)

Previously, qualifiedValueShape only included qualifiedMinCount. This meant that a graph was valid in which the specified path did not exist at all.

* Add missing minCount constraints (#11)

* Adapt property shapes to changed default branch representation (#11)

* Include number of violations in validation response (#19)

* Show share of fulfilled criteria, v1 (#19)

* Adjust button of progress bar (#19)

* Adapt checks for files in root directory of default branch (#11)

* Use properties from the Software Description Ontology (#24)

* Integration tests for validation of FAIR project type, part 1 (#18)

* Use camelCase for own properties (as in SDO) (#24)

* Replace "has_section" property with more specific ones from SDO (#24)

* Integration tests for validation of FAIR project type, part 2 (#18)

* Introduce mocking (#18)

* Remove OWL part (#25)

* Fix ZeroDivisionError in benchmark.py (#26)

* Adapt FAIR criteria as a result of tests with 26 repos (#14)

* Remove "using" as keyword for usage documentation because of false positives (#14)

* Recognize all keywords per heading (#31) (#33)

* Improve verbalization on validation and specification page (#34)

* Add sh:message to node- and property-shapes (#29)

* Use messages from the validation report in verbalization (#29)

* Add sh:message to node- and property-shapes (#29)

* Use messages from the validation report in verbalization (#29)

* Make check for open issues more precise

* Display verbalized explanation as an unordered list (#29)

* Extract quality criteria from the shapes graph via RDFLib (#30)

* Add descriptions to the node- and property shapes (#30)

* Use Markdown to format descriptions (#30)

* Use adapted Markdown renderer (#30)

* Update Node and package versions

* Add information about SW requirements and citation to README.md

* Organize quality criteria in Markdown tables (#30)

* Correct cardinality in README.md

* Include lower-case letters in the DOI regex

* Add code and resulting files of the quantitative evaluation.

* Add information on how to execute the quantitative evaluation

* benchmark fusion

* change benchmark to scatterplot

* tests with scatter plot

* reran benchmark

* refactored evaluation

* refactored evaluation

* formatting benchmark results

* cleanup

* statistical analysis of runtime benchmark results

* updated benchmark figures

* validation of benchmark results

* validation of benchmark results

* reran benchmarks with webseite URI instead of literal

* changed styling of diagrams

---------

Co-authored-by: Leon Martin <Leon@Home>
Co-authored-by: Leon Martin <lema@work>
Co-authored-by: Tobias Hummel <71486844+Tobias-TH@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant