Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vectorize impedance matrix calculation for different expansion points #130

Merged
merged 18 commits into from
Jan 25, 2022
Merged

Vectorize impedance matrix calculation for different expansion points #130

merged 18 commits into from
Jan 25, 2022

Conversation

WillemWybo
Copy link
Collaborator

@WillemWybo WillemWybo commented Jun 4, 2021 •
edited
Loading

Runtime original 'compartmentfitter.fitModel()' call for the BAC-firing example:
>>> Elapsed time fitModel call: 128.455 s
Runtime new 'compartmentfitter.fitModel()' call:
>>> Elapsed time fitModel call: 33.412 s
On a 3.1GHz Intel Core i5 with 16 GB 2133 MHz LPDDR3 memory.

@WillemWybo WillemWybo requested a review from jakobj June 4, 2021 07:48
@WillemWybo WillemWybo linked an issue Jun 4, 2021 that may be closed by this pull request
Vectorize impedance matrix calculation for different channel activations #118
Closed
jakobj
jakobj requested changes Nov 29, 2021
View reviewed changes
Copy link
Member

@jakobj jakobj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! 🚀

i went through the changes, but unfortunately can not check whether they are conceptually correct, so i have to rely on your judgement and the testsuite. i've added some comments that should be addressed before merging.

neat/tools/fittools/compartmentfitter.py Outdated Show resolved Hide resolved
neat/tools/fittools/compartmentfitter.py Outdated Show resolved Hide resolved
neat/trees/greenstree.py Show resolved Hide resolved
neat/trees/greenstree.py Show resolved Hide resolved
neat/trees/greenstree.py Outdated Show resolved Hide resolved
tests/test_compartmentfitter.py Outdated Show resolved Hide resolved
tests/test_greenstree.py Outdated Show resolved Hide resolved
neat/tools/fittools/compartmentfitter.py Outdated Show resolved Hide resolved
neat/tools/fittools/compartmentfitter.py Show resolved Hide resolved
@jakobj jakobj added this to the v0.9.2 milestone Nov 29, 2021
@jakobj jakobj added the enhancement New feature or request label Nov 29, 2021
@WillemWybo WillemWybo merged commit 2329330 into unibe-cns:master Jan 25, 2022
@WillemWybo WillemWybo deleted the enh/vectorize-expansion-points branch June 14, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobj jakobj jakobj requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.9.2
Development

Successfully merging this pull request may close these issues.

Vectorize impedance matrix calculation for different channel activations
2 participants
@WillemWybo @jakobj