Feature/scratch from scratch #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # paket.dependencies # paket.lock
…c/bob-scratch into feature/scratch-from-scratch
Feature/6 scratch fixes
Fix collectionuser creation
retohugi
reviewed
Feb 7, 2018
| @@ -0,0 +1,95 @@ | |||
| <# | |||
There was a problem hiding this comment.
Can we rename this to "ScratchHostHeaderTask, please?
retohugi
reviewed
Feb 7, 2018
| the SQL server. | ||
|
|
||
| .EXAMPLE | ||
| Enable-ScSite |
There was a problem hiding this comment.
Example does not really make sense i guess :)
retohugi
reviewed
Feb 7, 2018
Unic.Bob.Scratch.nuspec
Outdated
| <requireLicenseAcceptance>false</requireLicenseAcceptance> | ||
| <description>Scratch install Sitecore with SIF.</description> | ||
| </metadata> | ||
| <files> | ||
| <file src="Installation.config" /> |
There was a problem hiding this comment.
if we manage to move/remove installation.config, this entry is not required anymore.
ernstjoss
reviewed
Feb 7, 2018
retohugi
reviewed
Feb 7, 2018
src/Scratch/Install-Sitecore12.ps1
Outdated
| @@ -0,0 +1,78 @@ | |||
| <# | |||
There was a problem hiding this comment.
Needs a better file name and an updated doc header. Maybe Install-SitecoreDevInstance?
retohugi
reviewed
Feb 7, 2018
| @@ -0,0 +1,48 @@ | |||
| <# | |||
There was a problem hiding this comment.
Eventually Install-SitecoreDevInstanceDatabases would make sense. Not sure if you guys plan to use this wrapper for any other situations than local dev? (and if it is only used on dev, do we need it?)
retohugi
approved these changes
Feb 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.