Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shown input value can be capitalized with attribute 'capitalize-input-shown' #53

Closed
wants to merge 1 commit into from

Conversation

paragonHex
Copy link
Collaborator

No description provided.

@@ -217,7 +225,7 @@
<template is="dom-if" if="{{!multi}}">
<paper-input
id="singleSelectionDropdown"
class="value-container"
class$="value-container [[capitalizeInputValueClass(capitalizeInputShown)]]"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change capitalizeInputValueClass to _capitalizeInputValueClass as it's a method used only inside the element.

Copy link
Collaborator

@adi130987 adi130987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update your develop branch, merge master into it, then merge develop into your branch, push the changes on your PR then modify the PR to develop, and not master

@paragonHex paragonHex closed this Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants