Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX for making it clear that a user needs to add locationsI for report generation in Cluster (Keep Open) #675

Closed
1 task done
sethgold8 opened this issue May 17, 2018 · 6 comments
Assignees

Comments

@sethgold8
Copy link
Contributor

sethgold8 commented May 17, 2018

Need to improve the UX so a user knows when reports are generated.

  • In the indicator list view (on all indicator list views be it CA, PA, CO, PP etc. Should show in all places in response parameters for IMO and only under "my planned action" lists if partner) at the top add a message if any indicator has no locations "Please make sure indicators have locations set for reports to be generated". Along with an exclamation mark next to "edit" link. Clicking edit or "!" will do same thing (open edit modal). If all indicators have locations then don't show any warnings.

Screen Shot 2018-06-04 at 11.18.44 AM.png

@unicef unicef deleted a comment from sethgold8 Jun 5, 2018
@chachra chachra removed the blocked label Jun 6, 2018
@chachra chachra added the Ready label Jun 6, 2018
@chachra
Copy link
Contributor

chachra commented Jun 6, 2018

Please add this data in the relevant API calls and add another person to handle the frontend piece of it.

@n1207n
Copy link
Contributor

n1207n commented Jun 6, 2018

Backend API for /api/indicator/<INDICATOR_TYPE>/ has locations serializer field per each Reportable.

If locations field is empty for Reportable, then we should show above UI message.

@chachra chachra assigned n1207n and rkrupinski and unassigned n1207n Jun 6, 2018
rkrupinski added a commit that referenced this issue Jun 7, 2018
@sethgold8
Copy link
Contributor Author

@rkrupinski

  • Needs to work for all indicator list views: CA, CO, PP

Right now its working well for adopted PAI

@sethgold8 sethgold8 changed the title UX for making it clear that a user needs to add locations in PAI for report generation in Cluster (Keep Open) UX for making it clear that a user needs to add locationsI for report generation in Cluster (Keep Open) Jun 7, 2018
@rkrupinski
Copy link
Contributor

@sethgold8 This does work for all the lists (in cluster-reporting) but my assumption was that this only makes sense if you're able to edit (given the warning message)

screen shot 2018-06-08 at 09 14 22

@sethgold8
Copy link
Contributor Author

sethgold8 commented Jun 8, 2018

@rkrupinski it's working good as is :)

  • let's not show the warning message for Cluster Activity Indicator list UI since we don't generate reports for CAI

@sethgold8
Copy link
Contributor Author

working good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants